From b443a5bc19e321b7030ee6f4ebfec49e1d3e0b24 Mon Sep 17 00:00:00 2001
From: ota-meshi <otameshiyo23@gmail.com>
Date: Wed, 1 Aug 2018 18:26:35 +0900
Subject: [PATCH 1/3] Add `vue/no-spaces-around-equal-signs-in-attribute` rule

---
 README.md                                     |   1 +
 ...-spaces-around-equal-signs-in-attribute.md |  25 ++++
 lib/index.js                                  |   1 +
 ...-spaces-around-equal-signs-in-attribute.js |  54 ++++++++
 ...-spaces-around-equal-signs-in-attribute.js | 128 ++++++++++++++++++
 5 files changed, 209 insertions(+)
 create mode 100644 docs/rules/no-spaces-around-equal-signs-in-attribute.md
 create mode 100644 lib/rules/no-spaces-around-equal-signs-in-attribute.js
 create mode 100644 tests/lib/rules/no-spaces-around-equal-signs-in-attribute.js

diff --git a/README.md b/README.md
index 7870ed231..93beeb650 100644
--- a/README.md
+++ b/README.md
@@ -230,6 +230,7 @@ Enforce all the rules in this category, as well as all higher priority rules, wi
 |    | Rule ID | Description |
 |:---|:--------|:------------|
 | :wrench: | [vue/component-name-in-template-casing](./docs/rules/component-name-in-template-casing.md) | enforce specific casing for the component naming style in template |
+| :wrench: | [vue/no-spaces-around-equal-signs-in-attribute](./docs/rules/no-spaces-around-equal-signs-in-attribute.md) | disallow spaces around equal signs in attribute |
 | :wrench: | [vue/script-indent](./docs/rules/script-indent.md) | enforce consistent indentation in `<script>` |
 
 ### Deprecated
diff --git a/docs/rules/no-spaces-around-equal-signs-in-attribute.md b/docs/rules/no-spaces-around-equal-signs-in-attribute.md
new file mode 100644
index 000000000..7ab72b26e
--- /dev/null
+++ b/docs/rules/no-spaces-around-equal-signs-in-attribute.md
@@ -0,0 +1,25 @@
+# disallow spaces around equal signs in attribute (vue/no-spaces-around-equal-signs-in-attribute)
+
+- :wrench: The `--fix` option on the [command line](https://eslint.org/docs/user-guide/command-line-interface#fixing-problems) can automatically fix some of the problems reported by this rule.
+
+This rule disallow spaces around equal signs in attribute.
+
+HTML5 allows spaces around equal signs. But space-less is easier to read, and groups entities better together.
+
+## :book: Rule Details
+
+:-1: Examples of **incorrect** code for this rule:
+
+```html
+<div class = "item">
+```
+
+:+1: Examples of **correct** code for this rule:
+
+```html
+<div class="item">
+```
+
+## Further Reading
+
+* [HTML5 Style Guide - W3Schools *Spaces and Equal Signs*](https://www.w3schools.com/html/html5_syntax.asp)
\ No newline at end of file
diff --git a/lib/index.js b/lib/index.js
index 702fd41e0..6e1cf6a0a 100644
--- a/lib/index.js
+++ b/lib/index.js
@@ -30,6 +30,7 @@ module.exports = {
     'no-reserved-keys': require('./rules/no-reserved-keys'),
     'no-shared-component-data': require('./rules/no-shared-component-data'),
     'no-side-effects-in-computed-properties': require('./rules/no-side-effects-in-computed-properties'),
+    'no-spaces-around-equal-signs-in-attribute': require('./rules/no-spaces-around-equal-signs-in-attribute'),
     'no-template-key': require('./rules/no-template-key'),
     'no-template-shadow': require('./rules/no-template-shadow'),
     'no-textarea-mustache': require('./rules/no-textarea-mustache'),
diff --git a/lib/rules/no-spaces-around-equal-signs-in-attribute.js b/lib/rules/no-spaces-around-equal-signs-in-attribute.js
new file mode 100644
index 000000000..ad6b960d5
--- /dev/null
+++ b/lib/rules/no-spaces-around-equal-signs-in-attribute.js
@@ -0,0 +1,54 @@
+/**
+ * @author Yosuke Ota
+ * issue https://github.com/vuejs/eslint-plugin-vue/issues/460
+ */
+'use strict'
+
+// ------------------------------------------------------------------------------
+// Requirements
+// ------------------------------------------------------------------------------
+
+const utils = require('../utils')
+
+// ------------------------------------------------------------------------------
+// Rule Definition
+// ------------------------------------------------------------------------------
+
+module.exports = {
+  meta: {
+    docs: {
+      description: 'disallow spaces around equal signs in attribute',
+      category: undefined,
+      url: 'https://github.com/vuejs/eslint-plugin-vue/blob/v5.0.0-beta.1/docs/rules/no-spaces-around-equal-signs-in-attribute.md'
+    },
+    fixable: 'whitespace',
+    schema: []
+  },
+
+  create (context) {
+    const sourceCode = context.getSourceCode()
+    return utils.defineTemplateBodyVisitor(context, {
+      'VAttribute' (node) {
+        if (!node.value) {
+          return
+        }
+        const range = [node.key.range[1], node.value.range[0]]
+        const eqText = sourceCode.text.slice(range[0], range[1])
+        const expect = eqText.trim()
+
+        if (eqText !== expect) {
+          context.report({
+            node: node.key,
+            loc: {
+              start: node.key.loc.end,
+              end: node.value.loc.start
+            },
+            message: 'Unexpected spaces found around equal signs.',
+            data: {},
+            fix: fixer => fixer.replaceTextRange(range, expect)
+          })
+        }
+      }
+    })
+  }
+}
diff --git a/tests/lib/rules/no-spaces-around-equal-signs-in-attribute.js b/tests/lib/rules/no-spaces-around-equal-signs-in-attribute.js
new file mode 100644
index 000000000..6077bfcd6
--- /dev/null
+++ b/tests/lib/rules/no-spaces-around-equal-signs-in-attribute.js
@@ -0,0 +1,128 @@
+/**
+ * @author Yosuke Ota
+ */
+'use strict'
+
+// ------------------------------------------------------------------------------
+// Requirements
+// ------------------------------------------------------------------------------
+
+const rule = require('../../../lib/rules/no-spaces-around-equal-signs-in-attribute')
+const RuleTester = require('eslint').RuleTester
+
+// ------------------------------------------------------------------------------
+// Tests
+// ------------------------------------------------------------------------------
+
+const tester = new RuleTester({
+  parser: 'vue-eslint-parser'
+})
+
+tester.run('no-spaces-around-equal-signs-in-attribute', rule, {
+  valid: [
+    '<template><div attr="value" /></template>',
+    '<template><div attr="" /></template>',
+    '<template><div attr=\'value\' /></template>',
+    '<template><div attr=value /></template>',
+    '<template><div attr /></template>',
+    '<template><div/></template>',
+    `<template>
+      <div
+        is="header"
+        v-for="item in items"
+        v-if="!visible"
+        v-once
+        id="uniqueID"
+        ref="header"
+        v-model="headerData"
+        myProp="prop"
+        @click="functionCall"
+        v-text="textContent">
+      </div>
+    </template>`
+  ],
+  invalid: [
+    {
+      code: '<template><div attr = "value" /></template>',
+      output: '<template><div attr="value" /></template>',
+      errors: ['Unexpected spaces found around equal signs.']
+    },
+    {
+      code: '<template><div attr = "" /></template>',
+      output: '<template><div attr="" /></template>',
+      errors: ['Unexpected spaces found around equal signs.']
+    },
+    {
+      code: '<template><div attr = \'value\' /></template>',
+      output: '<template><div attr=\'value\' /></template>',
+      errors: ['Unexpected spaces found around equal signs.']
+    },
+    {
+      code: '<template><div attr = value /></template>',
+      output: '<template><div attr=value /></template>',
+      errors: ['Unexpected spaces found around equal signs.']
+    },
+
+    {
+      code: '<template><div attr \t\n   =   \t\n "value" /></template>',
+      output: '<template><div attr="value" /></template>',
+      errors: ['Unexpected spaces found around equal signs.']
+    },
+    {
+      code: '<template><div attr ="value" /></template>',
+      output: '<template><div attr="value" /></template>',
+      errors: ['Unexpected spaces found around equal signs.']
+    },
+    {
+      code: '<template><div attr= "value" /></template>',
+      output: '<template><div attr="value" /></template>',
+      errors: ['Unexpected spaces found around equal signs.']
+    },
+
+    {
+      code:
+        `<template>
+          <div
+            is = "header"
+            v-for = "item in items"
+            v-if = "!visible"
+            v-once
+            id = "uniqueID"
+            ref = "header"
+            v-model = "headerData"
+            myProp = "prop"
+            @click = "functionCall"
+            v-text = "textContent">
+          </div>
+        </template>`,
+
+      output:
+
+        `<template>
+          <div
+            is="header"
+            v-for="item in items"
+            v-if="!visible"
+            v-once
+            id="uniqueID"
+            ref="header"
+            v-model="headerData"
+            myProp="prop"
+            @click="functionCall"
+            v-text="textContent">
+          </div>
+        </template>`,
+      errors: [
+        'Unexpected spaces found around equal signs.',
+        'Unexpected spaces found around equal signs.',
+        'Unexpected spaces found around equal signs.',
+        'Unexpected spaces found around equal signs.',
+        'Unexpected spaces found around equal signs.',
+        'Unexpected spaces found around equal signs.',
+        'Unexpected spaces found around equal signs.',
+        'Unexpected spaces found around equal signs.',
+        'Unexpected spaces found around equal signs.'
+      ]
+    }
+  ]
+})

From 4f3f1c27e422fe7c6236b58eca106605907d6c98 Mon Sep 17 00:00:00 2001
From: yosuke ota <otameshiyo23@gmail.com>
Date: Sun, 12 Aug 2018 15:21:43 +0900
Subject: [PATCH 2/3] Add check that error message location is correct.

---
 ...-spaces-around-equal-signs-in-attribute.js | 146 +++++++++++++++---
 1 file changed, 126 insertions(+), 20 deletions(-)

diff --git a/tests/lib/rules/no-spaces-around-equal-signs-in-attribute.js b/tests/lib/rules/no-spaces-around-equal-signs-in-attribute.js
index 6077bfcd6..7bd090f3e 100644
--- a/tests/lib/rules/no-spaces-around-equal-signs-in-attribute.js
+++ b/tests/lib/rules/no-spaces-around-equal-signs-in-attribute.js
@@ -45,40 +45,94 @@ tester.run('no-spaces-around-equal-signs-in-attribute', rule, {
     {
       code: '<template><div attr = "value" /></template>',
       output: '<template><div attr="value" /></template>',
-      errors: ['Unexpected spaces found around equal signs.']
+      errors: [
+        {
+          message: 'Unexpected spaces found around equal signs.',
+          line: 1,
+          column: 20,
+          endLine: 1,
+          endColumn: 23
+        }
+      ]
     },
     {
       code: '<template><div attr = "" /></template>',
       output: '<template><div attr="" /></template>',
-      errors: ['Unexpected spaces found around equal signs.']
+      errors: [
+        {
+          message: 'Unexpected spaces found around equal signs.',
+          line: 1,
+          column: 20,
+          endLine: 1,
+          endColumn: 23
+        }
+      ]
     },
     {
       code: '<template><div attr = \'value\' /></template>',
       output: '<template><div attr=\'value\' /></template>',
-      errors: ['Unexpected spaces found around equal signs.']
+      errors: [
+        {
+          message: 'Unexpected spaces found around equal signs.',
+          line: 1,
+          column: 20,
+          endLine: 1,
+          endColumn: 23
+        }
+      ]
     },
     {
       code: '<template><div attr = value /></template>',
       output: '<template><div attr=value /></template>',
-      errors: ['Unexpected spaces found around equal signs.']
+      errors: [
+        {
+          message: 'Unexpected spaces found around equal signs.',
+          line: 1,
+          column: 20,
+          endLine: 1,
+          endColumn: 23
+        }
+      ]
     },
-
     {
       code: '<template><div attr \t\n   =   \t\n "value" /></template>',
       output: '<template><div attr="value" /></template>',
-      errors: ['Unexpected spaces found around equal signs.']
+      errors: [
+        {
+          message: 'Unexpected spaces found around equal signs.',
+          line: 1,
+          column: 20,
+          endLine: 3,
+          endColumn: 2
+        }
+      ]
     },
     {
       code: '<template><div attr ="value" /></template>',
       output: '<template><div attr="value" /></template>',
-      errors: ['Unexpected spaces found around equal signs.']
+      errors: [
+        {
+          message: 'Unexpected spaces found around equal signs.',
+          line: 1,
+          column: 20,
+          endLine: 1,
+          endColumn: 22
+        }
+      ]
     },
     {
       code: '<template><div attr= "value" /></template>',
       output: '<template><div attr="value" /></template>',
-      errors: ['Unexpected spaces found around equal signs.']
+      errors: [
+        {
+          message: 'Unexpected spaces found around equal signs.',
+          line: 1,
+          column: 20,
+          endLine: 1,
+          endColumn: 22
+        }
+      ]
     },
-
     {
       code:
         `<template>
@@ -95,9 +149,7 @@ tester.run('no-spaces-around-equal-signs-in-attribute', rule, {
             v-text = "textContent">
           </div>
         </template>`,
-
       output:
-
         `<template>
           <div
             is="header"
@@ -113,15 +165,69 @@ tester.run('no-spaces-around-equal-signs-in-attribute', rule, {
           </div>
         </template>`,
       errors: [
-        'Unexpected spaces found around equal signs.',
-        'Unexpected spaces found around equal signs.',
-        'Unexpected spaces found around equal signs.',
-        'Unexpected spaces found around equal signs.',
-        'Unexpected spaces found around equal signs.',
-        'Unexpected spaces found around equal signs.',
-        'Unexpected spaces found around equal signs.',
-        'Unexpected spaces found around equal signs.',
-        'Unexpected spaces found around equal signs.'
+        {
+          message: 'Unexpected spaces found around equal signs.',
+          line: 3,
+          column: 15,
+          endLine: 3,
+          endColumn: 18
+        },
+        {
+          message: 'Unexpected spaces found around equal signs.',
+          line: 4,
+          column: 18,
+          endLine: 4,
+          endColumn: 21
+        },
+        {
+          message: 'Unexpected spaces found around equal signs.',
+          line: 5,
+          column: 17,
+          endLine: 5,
+          endColumn: 20
+        },
+        {
+          message: 'Unexpected spaces found around equal signs.',
+          line: 7,
+          column: 15,
+          endLine: 7,
+          endColumn: 18
+        },
+        {
+          message: 'Unexpected spaces found around equal signs.',
+          line: 8,
+          column: 16,
+          endLine: 8,
+          endColumn: 19
+        },
+        {
+          message: 'Unexpected spaces found around equal signs.',
+          line: 9,
+          column: 20,
+          endLine: 9,
+          endColumn: 23
+        },
+        {
+          message: 'Unexpected spaces found around equal signs.',
+          line: 10,
+          column: 19,
+          endLine: 10,
+          endColumn: 22
+        },
+        {
+          message: 'Unexpected spaces found around equal signs.',
+          line: 11,
+          column: 19,
+          endLine: 11,
+          endColumn: 22
+        },
+        {
+          message: 'Unexpected spaces found around equal signs.',
+          line: 12,
+          column: 19,
+          endLine: 12,
+          endColumn: 22
+        }
       ]
     }
   ]

From a4ca0514a3da80e50521f136fdc5aec06e54d9fa Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Micha=C5=82=20Sajn=C3=B3g?= <msajnog93@gmail.com>
Date: Mon, 13 Aug 2018 23:44:04 +0200
Subject: [PATCH 3/3] Fix rule URL

---
 lib/rules/no-spaces-around-equal-signs-in-attribute.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/rules/no-spaces-around-equal-signs-in-attribute.js b/lib/rules/no-spaces-around-equal-signs-in-attribute.js
index ad6b960d5..e2e0766be 100644
--- a/lib/rules/no-spaces-around-equal-signs-in-attribute.js
+++ b/lib/rules/no-spaces-around-equal-signs-in-attribute.js
@@ -19,7 +19,7 @@ module.exports = {
     docs: {
       description: 'disallow spaces around equal signs in attribute',
       category: undefined,
-      url: 'https://github.com/vuejs/eslint-plugin-vue/blob/v5.0.0-beta.1/docs/rules/no-spaces-around-equal-signs-in-attribute.md'
+      url: 'https://github.com/vuejs/eslint-plugin-vue/blob/v5.0.0-beta.2/docs/rules/no-spaces-around-equal-signs-in-attribute.md'
     },
     fixable: 'whitespace',
     schema: []