skip transition when element is hidden (fix #1322)

yyx990803 · yyx990803 · commit c4db06e6bf49 · 2015-09-16T21:40:56.000-04:00
diff --git a/src/transition/transition.js b/src/transition/transition.js
@@ -286,7 +286,9 @@ p.getCssTransitionType = function (className) {
     // CSS transitions.
     document.hidden ||
     // explicit js-only transition
-    (this.hooks && this.hooks.css === false)
+    (this.hooks && this.hooks.css === false) ||
+    // element is hidden
+    isHidden(this.el)
   ) {
     return
   }
@@ -336,4 +338,18 @@ p.setupCssCb = function (event, cb) {
   _.on(el, event, onEnd)
 }
 
+/**
+ * Check if an element is hidden - in that case we can just
+ * skip the transition alltogether.
+ *
+ * @param {Element} el
+ * @return {Boolean}
+ */
+
+function isHidden (el) {
+  return el.style.display === 'none' ||
+    el.style.visibility === 'hidden' ||
+    el.hidden
+}
+
 module.exports = Transition
