Skip to content

triggering a transitionend event after enter transition is done in in-out mode causes error #1241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nkovacs opened this issue Sep 2, 2015 · 1 comment
Closed

triggering a transitionend event after enter transition is done in in-out mode causes error #1241

nkovacs opened this issue Sep 2, 2015 · 1 comment

Comments

@nkovacs
Copy link

nkovacs commented Sep 2, 2015

It only happens with in-out mode. The css transition that triggers the transitionend event is entirely unrelated to the component transition, which in the example uses js callbacks, and has already finished by the time the transitionend event is called.

http://jsfiddle.net/nkovacs/h800dpx2/

Uncaught TypeError: Cannot read property 'parentNode' of null caused by child.$el being null here
@yyx990803
Copy link
Member

Just add css: false to your transition: http://vuejs.org/guide/transitions.html#JavaScript_Only_Transitions (see the red tip at the end of section)

@nkovacs nkovacs mentioned this issue Sep 3, 2015
Closed
nkovacs added a commit to nkovacs/vue that referenced this issue Sep 3, 2015
@nkovacs
Don't set up css transition callback if there's a js callback.
b8b489e 
Fixes vuejs#1241
@nkovacs nkovacs mentioned this issue Sep 3, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yyx990803 @nkovacs