Skip to content

Firefox warning TypeError: mutating the [[Prototype]]... #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cdekok opened this issue Jul 6, 2014 · 4 comments
Closed

Firefox warning TypeError: mutating the [[Prototype]]... #339

cdekok opened this issue Jul 6, 2014 · 4 comments

Comments

@cdekok
Copy link

cdekok commented Jul 6, 2014

On this line firefox gives a warning: https://github.com/yyx990803/vue/blob/fe996b388971b014279b1f90df26ef95d8b00f05/dist/vue.js#L2458

TypeError: mutating the [[Prototype]] of an object will cause your code to run very slowly; instead create the object with the correct initial [[Prototype]] value using Object.create

@yyx990803
Copy link
Member

What verison of FF? Is this just a warning or an error that breaks the execution?

@yyx990803
Copy link
Member

Ok, looks like they recently added this in FF 30. While this is an annoying message, it should not affect the behavior of Vue since there are A LOT of libraries that depend on the __proto__ hack and FF has to maintain the backwards compatibility. The perf implications are negligible in most use cases with Vue.

@paperscissors
Copy link

i'm noticing integration with components on firefox 30 is extremely slow--- it keeps spitting out this error and spinning.

works fine on webkit browsers. and it's a small set of stuff it's rendering.

@yyx990803
Copy link
Member

Why are you using FF30 anyway?... it's like 15 versions behind...
On Tue, Jun 14, 2016 at 7:20 PM paperscissors notifications@github.com
wrote:

i'm noticing integration with components on firefox 30 is extremely
slow--- it keeps spitting out this error and spinning.

works fine on webkit browsers. and it's a small set of stuff it's
rendering.


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#339 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAefXiMORsKw-d_h66AGHMeMCRrKsr5Fks5qLzdXgaJpZM4CKkGY
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants