Skip to content

Found Bug #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rhinel opened this issue Jun 7, 2017 · 0 comments · Fixed by #254
Closed

Found Bug #202

rhinel opened this issue Jun 7, 2017 · 0 comments · Fixed by #254

Comments

@rhinel
Copy link

rhinel commented Jun 7, 2017

In file named ItemView.vue

at line 80~89

the function 'fetchComments' without an 'else'

fix like this:

function fetchComments (store, item) {
  if (item && item.kids) {
    return store.dispatch('FETCH_ITEMS', {
      ids: item.kids
    }).then(() => Promise.all(item.kids.map(id => {
      return fetchComments(store, store.state.items[id])
    })))
  } else {         // add this
    return Promise.resolve()
  }
}
yyx990803 pushed a commit that referenced this issue Sep 21, 2017
* close issues: close #202, close #231
close prs: close #209, close #216, close #244

* fallback false, remove unused `glob`

* upgrade vuex-router-sync, fix #221, fix #218, fix #208, fix #207

* lock firebase at version 4.1.3 (firebase/firebase-js-sdk#157 (comment))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant