From 1ca8701234365296959d2d9289500788204de99e Mon Sep 17 00:00:00 2001 From: kazuya kawaguchi Date: Fri, 27 Jan 2017 20:44:33 +0900 Subject: [PATCH 1/2] revert default name option based on filename related: #495 if several unnamed components have the same filename, occured endless loop. Closes #596 --- lib/component-normalizer.js | 6 ------ lib/loader.js | 4 ---- test/test.js | 1 - 3 files changed, 11 deletions(-) diff --git a/lib/component-normalizer.js b/lib/component-normalizer.js index b8fcb9e77..486b5370f 100644 --- a/lib/component-normalizer.js +++ b/lib/component-normalizer.js @@ -1,5 +1,4 @@ module.exports = function normalizeComponent ( - name, scriptExports, compiledTemplate, scopeId, @@ -26,11 +25,6 @@ module.exports = function normalizeComponent ( ? scriptExports.options : scriptExports - // default name option based on filename - if (options.name == null) { - options.name = name - } - // render functions if (compiledTemplate) { options.render = compiledTemplate.render diff --git a/lib/loader.js b/lib/loader.js index 0621f67da..2a54487a9 100644 --- a/lib/loader.js +++ b/lib/loader.js @@ -243,7 +243,6 @@ module.exports = function (content) { // we require the component normalizer function, and call it like so: // normalizeComponent( - // name, // scriptExports, // compiledTemplate, // scopeId, @@ -251,9 +250,6 @@ module.exports = function (content) { // ) output += 'var Component = require("' + componentNormalizerPath + '")(\n' - // name - output += ' /* name */\n ' + JSON.stringify(path.parse(filePath).name) + ',\n' - //