From f4796384fc1fb18577a1c2acb027953ee6dc2988 Mon Sep 17 00:00:00 2001 From: Lachlan Miller Date: Mon, 21 Jun 2021 19:57:44 +1000 Subject: [PATCH 1/2] chore: fail to repro 1766 --- test/resources/components/Form.vue | 6 ++++++ test/resources/components/LoginForm.vue | 25 +++++++++++++++++++++++ test/specs/mounting-options/slots.spec.js | 9 +++++++- 3 files changed, 39 insertions(+), 1 deletion(-) create mode 100644 test/resources/components/Form.vue create mode 100644 test/resources/components/LoginForm.vue diff --git a/test/resources/components/Form.vue b/test/resources/components/Form.vue new file mode 100644 index 000000000..2f97f4ce6 --- /dev/null +++ b/test/resources/components/Form.vue @@ -0,0 +1,6 @@ + diff --git a/test/resources/components/LoginForm.vue b/test/resources/components/LoginForm.vue new file mode 100644 index 000000000..4e0628502 --- /dev/null +++ b/test/resources/components/LoginForm.vue @@ -0,0 +1,25 @@ + + + diff --git a/test/specs/mounting-options/slots.spec.js b/test/specs/mounting-options/slots.spec.js index 3c2997def..42971c28b 100644 --- a/test/specs/mounting-options/slots.spec.js +++ b/test/specs/mounting-options/slots.spec.js @@ -5,7 +5,14 @@ import ComponentAsAClass from '~resources/components/component-as-a-class.vue' import ComponentWithParentName from '~resources/components/component-with-parent-name.vue' import { describeWithShallowAndMount, vueVersion } from '~resources/utils' import { itDoNotRunIf } from 'conditional-specs' -import { mount, createLocalVue } from 'packages/test-utils/src' +import LoginForm, { FormError } from '~resources/components/LoginForm.vue' +import { mount, createLocalVue, shallowMount } from 'packages/test-utils/src' + +it('fails to reproduce https://github.com/vuejs/vue-test-utils/issues/1766', () => { + const localVue = createLocalVue() + const wrapper = shallowMount(LoginForm, { localVue }) + expect(wrapper.findComponent(FormError).props('show')).toBeTruthy() +}) describeWithShallowAndMount('options.slots', mountingMethod => { it('mounts component with default slot if passed component in slot object', () => { From 3ee6c9ba19691ac40ed3796ef553c84ee7a3fdb2 Mon Sep 17 00:00:00 2001 From: Lachlan Miller Date: Mon, 21 Jun 2021 20:03:59 +1000 Subject: [PATCH 2/2] chore: update example --- test/resources/components/Form.vue | 2 +- test/resources/components/LoginForm.vue | 2 +- test/specs/mounting-options/slots.spec.js | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/test/resources/components/Form.vue b/test/resources/components/Form.vue index 2f97f4ce6..5fe16ecc0 100644 --- a/test/resources/components/Form.vue +++ b/test/resources/components/Form.vue @@ -1,6 +1,6 @@ diff --git a/test/resources/components/LoginForm.vue b/test/resources/components/LoginForm.vue index 4e0628502..d1d886345 100644 --- a/test/resources/components/LoginForm.vue +++ b/test/resources/components/LoginForm.vue @@ -1,7 +1,7 @@ diff --git a/test/specs/mounting-options/slots.spec.js b/test/specs/mounting-options/slots.spec.js index 42971c28b..3ff29d3c7 100644 --- a/test/specs/mounting-options/slots.spec.js +++ b/test/specs/mounting-options/slots.spec.js @@ -6,12 +6,12 @@ import ComponentWithParentName from '~resources/components/component-with-parent import { describeWithShallowAndMount, vueVersion } from '~resources/utils' import { itDoNotRunIf } from 'conditional-specs' import LoginForm, { FormError } from '~resources/components/LoginForm.vue' -import { mount, createLocalVue, shallowMount } from 'packages/test-utils/src' +import { mount, createLocalVue } from 'packages/test-utils/src' -it('fails to reproduce https://github.com/vuejs/vue-test-utils/issues/1766', () => { +it.only('fails to reproduce https://github.com/vuejs/vue-test-utils/issues/1766', () => { const localVue = createLocalVue() - const wrapper = shallowMount(LoginForm, { localVue }) - expect(wrapper.findComponent(FormError).props('show')).toBeTruthy() + const wrapper = mount(LoginForm, { localVue }) + expect(wrapper.findComponent(FormError).props('show')).toBe('blah') }) describeWithShallowAndMount('options.slots', mountingMethod => {