fix: check for parentNode before calling .meta on it

rigor789 · rigor789 · commit 45cb46d5432f · 2018-04-22T14:13:38.000+02:00
diff --git a/platform/nativescript/renderer/utils.js b/platform/nativescript/renderer/utils.js
@@ -15,11 +15,15 @@ export function isContentView(view) {
 }
 
 export function insertChild(parentNode, childNode, atIndex = -1) {
+  if (!parentNode) {
+    return
+  }
+
   if (typeof parentNode.meta.insertChild === 'function') {
     return parentNode.meta.insertChild(parentNode, childNode, atIndex)
   }
 
-  if (!parentNode || childNode.meta.skipAddToDom) {
+  if (childNode.meta.skipAddToDom) {
     return
   }
 
@@ -55,11 +59,15 @@ export function insertChild(parentNode, childNode, atIndex = -1) {
 }
 
 export function removeChild(parentNode, childNode) {
+  if (!parentNode) {
+    return
+  }
+
   if (typeof parentNode.meta.removeChild === 'function') {
     return parentNode.meta.removeChild(parentNode, childNode)
   }
 
-  if (!parentNode || childNode.meta.skipAddToDom) {
+  if (childNode.meta.skipAddToDom) {
     return
   }
 

Original file line number	Diff line number	Diff line change
`@@ -15,11 +15,15 @@ export function isContentView(view) {`
`15`	`15`	`}`
`16`	`16`
`17`	`17`	`export function insertChild(parentNode, childNode, atIndex = -1) {`
	`18`	`+ if (!parentNode) {`
	`19`	`+ return`
	`20`	`+ }`
	`21`	`+`
`18`	`22`	`if (typeof parentNode.meta.insertChild === 'function') {`
`19`	`23`	`return parentNode.meta.insertChild(parentNode, childNode, atIndex)`
`20`	`24`	`}`
`21`	`25`
`22`		`- if (!parentNode \|\| childNode.meta.skipAddToDom) {`
	`26`	`+ if (childNode.meta.skipAddToDom) {`
`23`	`27`	`return`
`24`	`28`	`}`
`25`	`29`
`@@ -55,11 +59,15 @@ export function insertChild(parentNode, childNode, atIndex = -1) {`
`55`	`59`	`}`
`56`	`60`
`57`	`61`	`export function removeChild(parentNode, childNode) {`
	`62`	`+ if (!parentNode) {`
	`63`	`+ return`
	`64`	`+ }`
	`65`	`+`
`58`	`66`	`if (typeof parentNode.meta.removeChild === 'function') {`
`59`	`67`	`return parentNode.meta.removeChild(parentNode, childNode)`
`60`	`68`	`}`
`61`	`69`
`62`		`- if (!parentNode \|\| childNode.meta.skipAddToDom) {`
	`70`	`+ if (childNode.meta.skipAddToDom) {`
`63`	`71`	`return`
`64`	`72`	`}`
`65`	`73`