fix: Detect boolean attributes and expand them if value is empty (nativescript-vue#171)

msaelices · msaelices · commit 72f21020ea54 · 2018-06-20T18:14:00.000+02:00
diff --git a/platform/nativescript/renderer/ViewNode.js b/platform/nativescript/renderer/ViewNode.js
@@ -96,12 +96,20 @@ export default class ViewNode {
     try {
       if (XML_ATTRIBUTES.indexOf(key) !== -1) {
         this.nativeView._applyXmlAttribute(key, value)
-      } else if (isAndroid && key.startsWith('android:')) {
-        set(this.nativeView, key.replace('android:', ''), value)
-      } else if (isIOS && key.startsWith('ios:')) {
-        set(this.nativeView, key.replace('ios:', ''), value)
       } else {
-        set(this.nativeView, key, value)
+        // detect expandable attrs for boolean values
+        // See https://vuejs.org/v2/guide/components-props.html#Passing-a-Boolean
+        if (typeof this.nativeView[key] === 'boolean' && value === '') {
+          value = true
+        }
+
+        if (isAndroid && key.startsWith('android:')) {
+          set(this.nativeView, key.replace('android:', ''), value)
+        } else if (isIOS && key.startsWith('ios:')) {
+          set(this.nativeView, key.replace('ios:', ''), value)
+        } else {
+          set(this.nativeView, key, value)
+        }
       }
     } catch (e) {
       // ignore
