fix: don't create view without data

rigor789 · rigor789 · commit ba4e9949cdea · 2018-06-19T15:01:02.000+02:00
fix nativescript-vue#229
diff --git a/platform/nativescript/runtime/components/v-template.js b/platform/nativescript/runtime/components/v-template.js
@@ -101,9 +101,9 @@ export class VueKeyedTemplate /* implements KeyedTemplate */ {
   }
 
   createView() {
-    const vnode = this._scopedFn(deepProxy({}))
-    const nativeView = patch(null, vnode).nativeView
-    nativeView[VUE_VIEW] = vnode
-    return nativeView
+    // we are returning null because we don't have the data here
+    // the view will be created in the `patchTemplate` method above.
+    // see https://github.com/nativescript-vue/nativescript-vue/issues/229#issuecomment-390330474
+    return null
   }
 }
diff --git a/samples/app/229.js b/samples/app/229.js
@@ -0,0 +1,24 @@
+const Vue = require('./nativescript-vue')
+
+Vue.config.silent = false
+
+new Vue({
+  data: {
+    items: [{ color: 'red' }, { color: 'blue' }]
+  },
+  template: `
+    <Frame>
+      <Page>
+        <ActionBar title="Issue #229" />
+        
+        <GridLayout>
+          <ListView for="item in items" class="list-group">
+            <v-template>
+              <Label :backgroundColor="item.color" :text="item.color" padding="50" />
+            </v-template>    
+          </ListView>
+        </GridLayout>
+      </Page>
+    </Frame>
+  `
+}).$start()

Original file line number	Diff line number	Diff line change
`@@ -101,9 +101,9 @@ export class VueKeyedTemplate /* implements KeyedTemplate */ {`
`101`	`101`	`}`
`102`	`102`
`103`	`103`	`createView() {`
`104`		`- const vnode = this._scopedFn(deepProxy({}))`
`105`		`- const nativeView = patch(null, vnode).nativeView`
`106`		`- nativeView[VUE_VIEW] = vnode`
`107`		`- return nativeView`
	`104`	`+ // we are returning null because we don't have the data here`
	`105`	+ // the view will be created in the `patchTemplate` method above.
	`106`	`+ // see https://github.com/nativescript-vue/nativescript-vue/issues/229#issuecomment-390330474`
	`107`	`+ return null`
`108`	`108`	`}`
`109`	`109`	`}`