feat: use the new run method instead of the old start method

rigor789 · rigor789 · commit d840d3cd8537 · 2018-05-07T17:03:49.000+02:00
BREAKING CHANGE: nativescript 3.x will no longer work with this change because application.run has
been added in 4.0
diff --git a/package.json b/package.json
@@ -74,7 +74,7 @@
     "rollup-watch": "^4.3.1",
     "semver": "^5.5.0",
     "set-value": "^2.0.0",
-    "tns-core-modules": "^3.4.0",
+    "tns-core-modules": "4.0.0",
     "util-inspect": "^0.1.8",
     "vue": "^2.5.16"
   },
diff --git a/platform/nativescript/runtime/index.js b/platform/nativescript/runtime/index.js
@@ -1,4 +1,4 @@
-import { start, on, launchEvent } from 'tns-core-modules/application'
+import { run, on, launchEvent } from 'tns-core-modules/application'
 import { warn } from 'core/util/index'
 import { patch } from './patch'
 import { mountComponent } from 'core/instance/lifecycle'
@@ -73,7 +73,7 @@ Vue.prototype.$start = function({ getRootView }) {
         : ensurePage(self.$el, self)
   })
 
-  start()
+  run()
 }
 
 export default Vue
diff --git a/samples/app/app-with-router-v2.js b/samples/app/app-with-router-v2.js
@@ -0,0 +1,85 @@
+const Vue = require('./nativescript-vue')
+const VueRouter = require('vue-router')
+const application = require('tns-core-modules/application')
+
+Vue.config.silent = false
+Vue.config.debug = true
+Vue.use(VueRouter)
+
+const Home = {
+  template: `
+    <Page>
+        <StackLayout>
+            <Button text="Go to details page..." @tap="$router.push('/detail/1')"/>
+        </StackLayout>
+    </Page>
+  `
+}
+
+const Detail = {
+  template: `
+    <Page>
+        <GridLayout rows="*, *, *">
+            <Label :text="'Detail for ' + $route.params.id" row="0"/>
+            <Button text="Tab 2" @tap="$router.replace($route.path + '/tab2')"/> 
+            
+            <router-view row="1" />
+        </GridLayout>
+    </Page>
+  `
+}
+
+const DetailTab1 = {
+  template: `
+    <Label text="detail tab 1" />
+  `
+}
+
+const DetailTab2 = {
+  template: `
+    <Label text="detail tab 2" />
+  `
+}
+
+const router = new VueRouter({
+  routes: [
+    { path: '/', component: Home },
+    {
+      path: '/detail/:id',
+      component: Detail,
+      children: [
+        { path: '/', component: DetailTab1 },
+        { path: 'tab2', component: DetailTab2 }
+      ]
+    },
+    { path: '*', redirect: '/' }
+  ]
+})
+
+router.push('/')
+
+application.android.on('activityBackPressed', args => {
+  if (router.history.stack.length > 1) {
+    router.back()
+    args.cancel = true
+  }
+})
+
+new Vue({
+  router,
+  template: `
+    <GridLayout rows="*, 80">
+      <Frame row="0">
+        <router-view :key="$route.path" />
+      </Frame>
+      
+      <Label :text="$route.path"
+            backgroundColor="#333" color="#eee" 
+            row="1" />
+    </GridLayout>  
+  `
+}).$start({
+  getRootView(vm) {
+    return vm.$el.nativeView
+  }
+})
diff --git a/samples/package.json b/samples/package.json
@@ -6,18 +6,18 @@
   "nativescript": {
     "id": "org.nativescript.vuesample",
     "tns-ios": {
-      "version": "3.4.0"
+      "version": "4.0.1"
     },
     "tns-android": {
-      "version": "3.4.0"
+      "version": "4.0.1"
     }
   },
   "dependencies": {
     "nativescript-gradient": "^2.0.1",
     "nativescript-pager": "^7.1.3",
     "nativescript-pro-ui": "^3.3.0",
     "nativescript-theme-core": "^1.0.4",
-    "tns-core-modules": "^3.4.0",
+    "tns-core-modules": "4.0.0",
     "vue-router": "^3.0.1",
     "vuex": "^3.0.1"
   },
