fix: action bar rendering - issue nativescript-vue#276 (nativescript-vue#278)

msaelices · rigor789 · commit db6df397d35c · 2018-07-09T12:03:33.000+02:00
* Fix the app-with-pages.js sample by adding a Frame root element and add two action bars in order to reproduce the issue nativescript-vue#276. * Fix page composition when does navigation issue (nativescript-vue#276), which wraps an already Page component in another Page component, losing its action bar.
diff --git a/platform/nativescript/util/index.js b/platform/nativescript/util/index.js
@@ -31,7 +31,7 @@ export function isUnknownElement(el) {
 }
 
 export function isPage(el) {
-  return el && el.tagName === 'page'
+  return el && el.tagName === 'nativepage'
 }
 
 /** @deprecated */
diff --git a/samples/app/app-with-pages.js b/samples/app/app-with-pages.js
@@ -2,9 +2,16 @@ const Vue = require('./nativescript-vue')
 
 const App = {
   template: `
-    <StackLayout>
-      <Button text="Open page" @tap="openPage" />
-    </StackLayout>
+  <Frame>
+    <Page>
+      <ActionBar class="action-bar" title="Home Page">
+        <ActionItem text="Action"></ActionItem>
+      </ActionBar>
+      <StackLayout>
+        <Button text="Open page" @tap="openPage" />
+      </StackLayout>
+    </Page>
+  </Frame>
   `,
 
   methods: {
@@ -16,11 +23,16 @@ const App = {
 
 const DetailsPage = {
   template: `
+  <Page>
+    <ActionBar class="action-bar" title="Details Page">
+      <ActionItem text="Action"></ActionItem>
+    </ActionBar>
     <StackLayout>
       <Label :text="'Details ' + Math.random()" />
       <Button text="another" @tap="openDetails" />
       <Button text="back" @tap="goBack" />
     </StackLayout>
+  </Page>
   `,
 
   methods: {

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ export function isUnknownElement(el) {`
`31`	`31`	`}`
`32`	`32`
`33`	`33`	`export function isPage(el) {`
`34`		`- return el && el.tagName === 'page'`
	`34`	`+ return el && el.tagName === 'nativepage'`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`/** @deprecated */`