feat(computedAsync): use globalThis.reportError as default onError (#4943)

babu-ch · web-flow · commit 226a229bc88e · 2025-08-08T01:29:41.000Z
diff --git a/packages/core/computedAsync/index.test.ts b/packages/core/computedAsync/index.test.ts
@@ -55,6 +55,28 @@ describe('computedAsync', () => {
     expectTypeOf(data2).toEqualTypeOf<ComputedRef<string>>()
   })
 
+  it('default onError in computedAsync uses globalThis.reportError', async () => {
+    const originalReportError = globalThis.reportError
+    const mockReportError = vi.fn()
+    globalThis.reportError = mockReportError
+
+    const error = new Error('An Error Message')
+    const func = vi.fn(async () => {
+      throw error
+    })
+
+    const data = computedAsync(func, undefined)
+
+    expect(func).toBeCalledTimes(1)
+
+    expect(data.value).toBeUndefined()
+
+    await nextTick()
+    expect(data.value).toBeUndefined()
+    expect(mockReportError).toHaveBeenCalledWith(error)
+    globalThis.reportError = originalReportError
+  })
+
   it('call onError when error is thrown', async () => {
     const errorMessage = shallowRef()
     const func = vi.fn(async () => {
diff --git a/packages/core/computedAsync/index.ts b/packages/core/computedAsync/index.ts
@@ -101,7 +101,7 @@ export function computedAsync<T>(
     flush = 'pre',
     evaluating = undefined,
     shallow = true,
-    onError = noop,
+    onError = globalThis.reportError ?? noop,
   } = options
 
   const started = shallowRef(!lazy)
