fix(onClickOutside): the order of overload signatures (#4839)

whiteyebrw · autofix-ci[bot] · ilyaliao · web-flow · commit d5812393c176 · 2025-07-28T04:38:37.000Z
Co-authored-by: autofix-ci[bot] &lt;114827586+autofix-ci[bot]@users.noreply.github.com&gt;
Co-authored-by: IlyaL &lt;ilyaliao324@gmail.com&gt;
Co-authored-by: Anthony Fu &lt;anthonyfu117@hotmail.com&gt;
diff --git a/packages/core/onClickOutside/index.ts b/packages/core/onClickOutside/index.ts
@@ -32,18 +32,19 @@ export interface OnClickOutsideOptions<Controls extends boolean = false> extends
 }
 
 export type OnClickOutsideHandler<
-  T extends {
-    detectIframe: OnClickOutsideOptions['detectIframe']
-    controls: boolean
-  } = { detectIframe: false, controls: false },
+  T extends OnClickOutsideOptions<boolean> = OnClickOutsideOptions,
 > = (
-  event: T['controls'] extends true ? Event | (T['detectIframe'] extends true
-    ? PointerEvent | FocusEvent
-    : PointerEvent) : T['detectIframe'] extends true
-    ? PointerEvent | FocusEvent
-    : PointerEvent,
+  event: (T['detectIframe'] extends true ? FocusEvent : never)
+    | (T['controls'] extends true ? Event : never)
+    | PointerEvent,
 ) => void
 
+interface OnClickOutsideControlsReturn {
+  stop: Fn
+  cancel: Fn
+  trigger: (event: Event) => void
+}
+
 let _iOSWorkaround = false
 
 /**
@@ -54,17 +55,21 @@ let _iOSWorkaround = false
  * @param handler
  * @param options
  */
-export function onClickOutside(
+export function onClickOutside<
+  T extends OnClickOutsideOptions,
+>(
   target: MaybeElementRef,
-  handler: OnClickOutsideHandler<{ detectIframe: OnClickOutsideOptions['detectIframe'], controls: true }>,
-  options: OnClickOutsideOptions<true>,
-): { stop: Fn, cancel: Fn, trigger: (event: Event) => void }
+  handler: OnClickOutsideHandler<T>,
+  options?: T
+): Fn
 
-export function onClickOutside(
+export function onClickOutside<
+  T extends OnClickOutsideOptions<true>,
+>(
   target: MaybeElementRef,
-  handler: OnClickOutsideHandler<{ detectIframe: OnClickOutsideOptions['detectIframe'], controls: false }>,
-  options?: OnClickOutsideOptions<false>,
-): Fn
+  handler: OnClickOutsideHandler<T>,
+  options: T
+): OnClickOutsideControlsReturn
 
 // Implementation
 export function onClickOutside(
