Skip to content

One of Anthony's avatars is breaking out #4777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
outslept opened this issue May 27, 2025 · 5 comments
Open

One of Anthony's avatars is breaking out #4777

outslept opened this issue May 27, 2025 · 5 comments

Comments

@outslept
Copy link

outslept commented May 27, 2025 •
edited
Loading

Funny bug, but on every page I've opened Anthony shows up twice in Contributors section (even tho his nickname is mentioned only once in contributors.json). For example - https://vueuse.org/core/useDocumentVisibility/#contributors

Image
@9romise
Copy link
Contributor

9romise commented May 28, 2025

The reason for this issue is that he uses two email addresses in git to commit.

@antfu
Copy link
Member

antfu commented May 28, 2025

We can do a dedupe based on the resolved avatar url

@9romise
Copy link
Contributor

9romise commented May 28, 2025 •
edited
Loading

I’m afraid we can't, as I’ve noticed the avatar URLs are generated by MD5 hashing the email addresses.

https://github.com/vueuse/vueuse/blob/main/scripts/changelog.ts#L57
https://github.com/vueuse/vueuse/blob/main/packages/.vitepress/theme/components/Contributors.vue#L15

@OrbisK
Copy link
Collaborator

OrbisK commented May 28, 2025

I tried to solve this a few months ago. The only solution I could find was to create a list of common aliases for regular contributors.

@antfu
Copy link
Member

antfu commented May 28, 2025

I tried to solve this a few months ago. The only solution I could find was to create a list of common aliases for regular contributors.

I don't mind doing that either

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@antfu @OrbisK @9romise @outslept