This patch fixes the speed degradation introduced by BUG#34984850 fix

nmariz · nmariz · commit 61c26311b49d · 2023-03-10T20:29:07.000Z
Change-Id: I1b3df4f8bceaefb57e434aad784f61b566e9c911
diff --git a/lib/mysql/connector/abstracts.py b/lib/mysql/connector/abstracts.py
@@ -1,4 +1,4 @@
-# Copyright (c) 2014, 2022, Oracle and/or its affiliates.
+# Copyright (c) 2014, 2023, Oracle and/or its affiliates.
 #
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License, version 2.0, as
@@ -887,7 +887,9 @@ def time_zone(self, value: str) -> None:
     @property
     def sql_mode(self) -> str:
         """Get the SQL mode"""
-        return self.info_query("SELECT @@session.sql_mode")[0]
+        if self._sql_mode is None:
+            self._sql_mode = self.info_query("SELECT @@session.sql_mode")[0]
+        return self._sql_mode
 
     @sql_mode.setter
     def sql_mode(self, value: Union[str, Sequence[int]]) -> None:
diff --git a/lib/mysql/connector/cursor.py b/lib/mysql/connector/cursor.py
@@ -436,13 +436,14 @@ def _process_params_dict(
         """Process query parameters given as dictionary"""
         res: Dict[bytes, Any] = {}
         try:
+            sql_mode = self._connection.sql_mode
             to_mysql = self._connection.converter.to_mysql
             escape = self._connection.converter.escape
             quote = self._connection.converter.quote
             for key, value in params.items():
                 conv = value
                 conv = to_mysql(conv)
-                conv = escape(conv, self._connection.sql_mode)
+                conv = escape(conv, sql_mode)
                 if not isinstance(value, Decimal):
                     conv = quote(conv)
                 res[key.encode()] = conv
@@ -458,11 +459,12 @@ def _process_params(
         """Process query parameters."""
         res = params[:]
         try:
+            sql_mode = self._connection.sql_mode
             to_mysql = self._connection.converter.to_mysql
             escape = self._connection.converter.escape
             quote = self._connection.converter.quote
             res = [to_mysql(value) for value in res]
-            res = [escape(value, self._connection.sql_mode) for value in res]
+            res = [escape(value, sql_mode) for value in res]
             res = [
                 quote(value) if not isinstance(params[i], Decimal) else value
                 for i, value in enumerate(res)
