fix: open connection count (gomodule#527)

rhnvrm · web-flow · commit bd964e5f79dd · 2020-10-26T15:46:48.000Z
This commit releases back the connection in the special
case, so that correct count is always maintained.
diff --git a/redis/pool.go b/redis/pool.go
@@ -377,6 +377,7 @@ func (p *Pool) waitVacantConn(ctx context.Context) (waited time.Duration, err er
 		// because `select` picks a random `case` if several of them are "ready".
 		select {
 		case <-ctx.Done():
+			p.ch <- struct{}{}
 			return 0, ctx.Err()
 		default:
 		}
diff --git a/redis/pool_test.go b/redis/pool_test.go
@@ -825,6 +825,32 @@ func TestWaitPoolGetContext(t *testing.T) {
 	defer c.Close()
 }
 
+func TestWaitPoolGetContextIssue520(t *testing.T) {
+	d := poolDialer{t: t}
+	p := &redis.Pool{
+		MaxIdle:   1,
+		MaxActive: 1,
+		Dial:      d.dial,
+		Wait:      true,
+	}
+	defer p.Close()
+	ctx1, cancel1 := context.WithTimeout(context.Background(), 1*time.Nanosecond)
+	defer cancel1()
+	c, err := p.GetContext(ctx1)
+	if err != context.DeadlineExceeded {
+		t.Fatalf("GetContext returned %v", err)
+	}
+	defer c.Close()
+
+	ctx2, cancel2 := context.WithCancel(context.Background())
+	defer cancel2()
+	c2, err := p.GetContext(ctx2)
+	if err != nil {
+		t.Fatalf("Get context returned %v", err)
+	}
+	defer c2.Close()
+}
+
 func TestWaitPoolGetContextWithDialContext(t *testing.T) {
 	d := poolDialer{t: t}
 	p := &redis.Pool{

Original file line number	Diff line number	Diff line change
`@@ -377,6 +377,7 @@ func (p *Pool) waitVacantConn(ctx context.Context) (waited time.Duration, err er`
`377`	`377`	// because `select` picks a random `case` if several of them are "ready".
`378`	`378`	`select {`
`379`	`379`	`case <-ctx.Done():`
	`380`	`+ p.ch <- struct{}{}`
`380`	`381`	`return 0, ctx.Err()`
`381`	`382`	`default:`
`382`	`383`	`}`