Pass tag/value validation errors to InvalidDocumentError

sschuberth · sschuberth · commit 93088a6a90d0 · 2017-01-03T14:39:27.000+01:00
diff --git a/spdx/document.py b/spdx/document.py
@@ -188,7 +188,7 @@ def files(self, value):
     def has_comment(self):
         return self.comment is not None
 
-    def validate(self, messages=[]):
+    def validate(self, messages = []):
         """Validate all fields of the document.
         messages - appends user friendly error messages to this list for display.
         """
diff --git a/spdx/writers/tagvalue.py b/spdx/writers/tagvalue.py
@@ -180,8 +180,9 @@ def write_document(document, out):
     """Writes out a tag value representation of the document.
     Out must implement a method write that takes a single string.
     """
-    if not document.validate():
-        raise InvalidDocumentError()
+    messages = []
+    if not document.validate(messages):
+        raise InvalidDocumentError(messages)
     # Write out document information
     out.write('# Document Information\n\n')
     version_value = 'SPDX-{0}.{1}'.format(document.version.major, document.version.minor)
