Skip to content

Duplicate registration of listeners after calling ShareButtons.update() #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wcoder opened this issue Sep 1, 2021 · 1 comment
Closed
Labels
Milestone

Comments

@wcoder
Copy link
Owner

wcoder commented Sep 1, 2021

Reported by @tnga in a possible fix #28

Previous added listeners to share buttons are re-added twice or multiple time when execute ShareButtons.update().
In browsers, if data-url or data-title or data-desc have been changed before calling ShareButtons.update(), the changes will not be considered because the previous added listeners with previous data value on share buttons will be executed on click event before the new added listeners after ShareButtons.update().

@wcoder wcoder added the bug label Sep 1, 2021
@wcoder
Copy link
Owner Author

wcoder commented Sep 5, 2021

Fixed by #30

@wcoder wcoder closed this as completed Sep 5, 2021
@wcoder wcoder added this to the vNext milestone Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant