Fixes NativeScript#1691.

atanasovg · atanasovg · commit 66936ff0c455 · 2016-03-03T18:03:27.000+02:00
diff --git a/ui/core/proxy.ts b/ui/core/proxy.ts
@@ -1,7 +1,6 @@
 ﻿import bindable = require("ui/core/bindable");
 import dependencyObservable = require("ui/core/dependency-observable");
 import definition = require("ui/core/proxy");
-import * as platform from "platform";
 import * as types from "utils/types";
 import * as observable from "data/observable";
 
@@ -71,13 +70,20 @@ export class ProxyObject extends bindable.Bindable implements definition.ProxyOb
         this._eachSetProperty(eachPropertyCallback);
     }
 
+    /**
+     * Checks whether the proxied native object has been created and properties may be applied to it.
+     */
+    protected _canApplyNativeProperty(): boolean {
+        return false;
+    }
+
     private _trySetNativeValue(property: dependencyObservable.Property, oldValue?:any, newValue?: any) {
         if (this._updatingJSPropertiesDict[property.name]) {
             // This is the case when a property has changed from the native side directly and we have received the "_onPropertyChanged" event while synchronizing our local cache
             return;
         }
 
-        if (platform.device.os === platform.platformNames.android && !this.android) {
+        if (!this._canApplyNativeProperty()) {
             // in android we have lazy loading and we do not have a native widget created yet, do not call the onSetNativeValue callback
             // properties will be synced when the widget is created
             return;
diff --git a/ui/core/view-common.ts b/ui/core/view-common.ts
@@ -1165,4 +1165,9 @@ export class View extends ProxyObject implements definition.View {
     public _onStylePropertyChanged(property: Property): void {
         //
     }
+
+    protected _canApplyNativeProperty(): boolean {
+        // Check for a valid _nativeView instance
+        return !!this._nativeView;
+    }
 }
diff --git a/utils/debug.ts b/utils/debug.ts
@@ -47,11 +47,12 @@ export class Source {
 	}
 }
 
-export class ScopeError implements Error {
+export class ScopeError extends Error {
 	private _child: Error;
 	private _message: string;
 	
-	constructor(child: Error, message?: string) {
+    constructor(child: Error, message?: string) {
+        super(message);
 		if (!child) {
 			throw new Error("Required child error!");
 		}

Original file line number	Diff line number	Diff line change
`@@ -1165,4 +1165,9 @@ export class View extends ProxyObject implements definition.View {`
`1165`	`1165`	`public _onStylePropertyChanged(property: Property): void {`
`1166`	`1166`	`//`
`1167`	`1167`	`}`
	`1168`	`+`
	`1169`	`+ protected _canApplyNativeProperty(): boolean {`
	`1170`	`+ // Check for a valid _nativeView instance`
	`1171`	`+ return !!this._nativeView;`
	`1172`	`+ }`
`1168`	`1173`	`}`
Original file line number	Diff line number	Diff line change
`@@ -47,11 +47,12 @@ export class Source {`
`47`	`47`	`}`
`48`	`48`	`}`
`49`	`49`
`50`		`-export class ScopeError implements Error {`
	`50`	`+export class ScopeError extends Error {`
`51`	`51`	`private _child: Error;`
`52`	`52`	`private _message: string;`
`53`	`53`
`54`		`- constructor(child: Error, message?: string) {`
	`54`	`+ constructor(child: Error, message?: string) {`
	`55`	`+ super(message);`
`55`	`56`	`if (!child) {`
`56`	`57`	`throw new Error("Required child error!");`
`57`	`58`	`}`