fix: real content hash accidentally overwrite user's code #19110
+350
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For maintainers only:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #14058
What kind of change does this PR introduce?
Introduce
optimization.realContentHash = 'prefixed'When
'prefixed'is used, RealContentHashPlugin will add a prefix ("__WEBPACK_RCH_PLACEHOLDER__"by default) forchunk.contentHashwhen creating the contentHash, so all the contentHashes will have the prefix, and contentHashes in generated code will also have the prefix, then RealContentHashPlugin will only replace the code that have this prefix, to avoid accidentally replace user's code.Did you add tests for your changes?
Yes
Does this PR introduce a breaking change?
No
The only breaking change is now before RealContentHashPlugin finish replacing,
assetInfo.contenthashwill have a prefix, I'm not sure whether this is will break other plugins, so I introduce a new optionoptimization.realContentHash = 'prefixed', and enable it whenfutureDefaultsis enabled,optimization.realContentHash = trueis still as is.What needs to be documented once your changes are merged?
optimization.realContentHash = 'prefixed'