refactor(es6): refactor IgnorePlugin to ES6 class #3638
Merged
+32
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One question on this, I converted all functions to arrow functions. Is this preferred or for unbound, unnamed functions should we be sticking with old function notation? I know this is something that will be determined once the es2015 style guide gets finalized |
|
Changes like this is much easier to review with LGTM if that matters! :D |
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactor (ES5 => ES6)
Did you add tests for your changes?
No functionality was changed, existing tests passed
If relevant, link to documentation update:
N/A
Summary
Refactors the IgnorePlugin to an ES6 class. Never contributed before, trying to get into the webpack codebase and understand it a bit more so this seemed like a good place to start. Let me know if I missed anything!
Does this PR introduce a breaking change?
Nope