Only check the protip kind if it's present on the protip

just3ws · just3ws · commit b24992bb7ce4 · 2014-10-20T17:44:51.000-05:00
diff --git a/app/models/protip.rb b/app/models/protip.rb
@@ -782,7 +782,13 @@ def images
     if self.new_record?
       self.links.select { |link| ProtipLink.is_image? link }
     else
-      protip_links.loaded? ? protip_links.select { |p| ProtipLink::IMAGE_KINDS.include?(p.kind.to_sym) }.map(&:url) : protip_links.where('kind in (?)', ProtipLink::IMAGE_KINDS).map(&:url)
+      if protip_links.loaded?
+        protip_links.select do |p|
+          ProtipLink::IMAGE_KINDS.include?(p.kind.to_sym) if p.kind
+        end.map(&:url).compact
+      else
+        protip_links.where('kind in (?)', ProtipLink::IMAGE_KINDS).map(&:url)
+      end
     end
   end
 
