fix: MacOS PTY flake when reading after command exists (coder#410)

kylecarbs · web-flow · commit 6caceacfb4f7 · 2022-03-08T09:49:09.000-06:00
The TTY wasn't bufferring properly because the FD was closed.
I did this initially to clone how creack/pty handles it, but it's
unnecessary because we get the entire PTY back to close.
diff --git a/pty/start_other.go b/pty/start_other.go
@@ -17,9 +17,6 @@ func startPty(cmd *exec.Cmd) (PTY, *os.Process, error) {
 	if err != nil {
 		return nil, nil, xerrors.Errorf("open: %w", err)
 	}
-	defer func() {
-		_ = tty.Close()
-	}()
 	cmd.SysProcAttr = &syscall.SysProcAttr{
 		Setsid:  true,
 		Setctty: true,
