Skip to content

Commit a37e61a

Browse files
authored
fix: make text colors legible (coder#3250)
* Update color palette * Edit dialog error colors * Format * Lighten links * Lighten link just in ErrorSummary * Format
1 parent 46564fb commit a37e61a

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

site/src/components/Dialog/Dialog.tsx

+3-3
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import MuiDialog, { DialogProps as MuiDialogProps } from "@material-ui/core/Dial
22
import MuiDialogTitle from "@material-ui/core/DialogTitle"
33
import InputAdornment from "@material-ui/core/InputAdornment"
44
import OutlinedInput, { OutlinedInputProps } from "@material-ui/core/OutlinedInput"
5-
import { darken, fade, makeStyles } from "@material-ui/core/styles"
5+
import { darken, fade, lighten, makeStyles } from "@material-ui/core/styles"
66
import SvgIcon from "@material-ui/core/SvgIcon"
77
import * as React from "react"
88
import { combineClasses } from "../../util/combineClasses"
@@ -200,10 +200,10 @@ const useButtonStyles = makeStyles((theme) => ({
200200
},
201201
errorButton: {
202202
"&.MuiButton-contained": {
203-
backgroundColor: theme.palette.error.main,
203+
backgroundColor: lighten(theme.palette.error.dark, 0.15),
204204
color: theme.palette.error.contrastText,
205205
"&:hover": {
206-
backgroundColor: darken(theme.palette.error.main, 0.3),
206+
backgroundColor: theme.palette.error.dark,
207207
"@media (hover: none)": {
208208
backgroundColor: "transparent",
209209
},

site/src/components/ErrorSummary/ErrorSummary.tsx

+2-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import Button from "@material-ui/core/Button"
22
import Collapse from "@material-ui/core/Collapse"
33
import IconButton from "@material-ui/core/IconButton"
44
import Link from "@material-ui/core/Link"
5-
import { darken, makeStyles, Theme } from "@material-ui/core/styles"
5+
import { darken, lighten, makeStyles, Theme } from "@material-ui/core/styles"
66
import CloseIcon from "@material-ui/icons/Close"
77
import RefreshIcon from "@material-ui/icons/Refresh"
88
import { ApiError, getErrorDetail, getErrorMessage } from "api/errors"
@@ -103,6 +103,7 @@ const useStyles = makeStyles<Theme, StyleProps>((theme) => ({
103103
},
104104
detailsLink: {
105105
cursor: "pointer",
106+
color: `${lighten(theme.palette.primary.light, 0.2)}`,
106107
},
107108
details: {
108109
marginTop: `${theme.spacing(2)}px`,

site/src/theme/palettes.ts

+3-1
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,11 @@ export const darkPalette: PaletteOptions = {
3434
info: {
3535
main: colors.blue[11],
3636
dark: colors.blue[15],
37+
contrastText: colors.gray[3],
3738
},
3839
error: {
39-
main: colors.red[11],
40+
main: colors.red[5],
4041
dark: colors.red[15],
42+
contrastText: colors.gray[3],
4143
},
4244
}

0 commit comments

Comments
 (0)