Skip to content

Commit e815204

Browse files
author
stonebig
committed
Revert "switch to pip for gz and zip packages"
This reverts commit aca399d.
1 parent aca399d commit e815204

File tree

1 file changed

+10
-12
lines changed

1 file changed

+10
-12
lines changed

winpython/wppm.py

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,7 @@ def install(self, package, install_options=None):
371371
assert package.is_compatible_with(self)
372372
tmp_fname = None
373373
# (tragic if pip) self.uninstall_existing(package)
374-
if package.fname.endswith(('.NOtar.gz', '.NOzip')):
374+
if package.fname.endswith(('.tar.gz', '.zip')):
375375
self._print(package, "Building")
376376
try:
377377
fname = utils.source_to_wininst(package.fname,
@@ -385,8 +385,8 @@ def install(self, package, install_options=None):
385385
package = Package(fname)
386386
self._print_done()
387387
# wheel addition
388-
if package.fname.endswith(('.whl', '.tar.gz', '.zip')):
389-
self.install_bdist_direct(package, install_options=install_options)
388+
if package.fname.endswith(('.whl')):
389+
self.install_bdist_wheel(package, install_options=install_options)
390390

391391
bname = osp.basename(package.fname)
392392
if bname.endswith('.exe'):
@@ -397,8 +397,7 @@ def install(self, package, install_options=None):
397397
elif bname.endswith('.msi'):
398398
self.install_bdist_msi(package)
399399
self.handle_specific_packages(package)
400-
if not package.fname.endswith(('.whl', '.tar.gz', '.zip')):
401-
package.save_log(self.logdir)
400+
package.save_log(self.logdir)
402401
if tmp_fname is not None:
403402
os.remove(tmp_fname)
404403

@@ -462,11 +461,10 @@ def handle_specific_packages(self, package):
462461
self.create_file(package, name, '.',
463462
contents.replace('.', './Lib/site-packages/%s' % package.name))
464463
# pyuic script
465-
tmp_string = r'''@echo off
466-
python "%WINPYDIR%\Lib\site-packages\package.name\uic\pyuic.py" %1 %2 %3 %4 %5 %6 %7 %8 %9'''
467-
468464
self.create_file(package, 'pyuic%s.bat' % package.name[-1],
469-
'Scripts', tmp_string.replace('package.name', package.name))
465+
'Scripts', r'''@echo off
466+
python "%WINPYDIR%\Lib\site-packages\%s\uic\pyuic.py" %1 %2 %3 %4 %5 %6 %7 %8 %9'''
467+
% package.name)
470468
# Adding missing __init__.py files (fixes Issue 8)
471469
uic_path = osp.join('Lib', 'site-packages', package.name, 'uic')
472470
for dirname in ('Loader', 'port_v2', 'port_v3'):
@@ -557,9 +555,9 @@ def install_bdist_wininst(self, package):
557555
self.copy_files(package, targetdir, 'DATA', '.')
558556
self._print_done()
559557

560-
def install_bdist_direct(self, package, install_options=None):
561-
"""Install a package directly !"""
562-
self._print(package, "Installing %s" % package.fname.split(".")[-1])
558+
def install_bdist_wheel(self, package, install_options=None):
559+
"""Install a wheel directly !"""
560+
self._print(package, "Installing Wheel")
563561
# targetdir = utils.extract_msi(package.fname, targetdir=self.target)
564562
try:
565563
fname = utils.direct_pip_install(package.fname,

0 commit comments

Comments
 (0)