Skip to content

Launchers don't forward command line arguments to batch scripts #1564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
firai opened this issue Apr 22, 2025 · 6 comments · Fixed by #1569 or #1572
Closed

Launchers don't forward command line arguments to batch scripts #1564

firai opened this issue Apr 22, 2025 · 6 comments · Fixed by #1569 or #1572

Comments

@firai
Copy link
Contributor

firai commented Apr 22, 2025

The exe launchers don't seem to forward command line arguments to the batch scripts. For example,

.\scripts\winjupyter_lab.bat "c:\"

opens JupyterLab with the notebook directory set as C:\, but

& '.\Jupyter Lab.exe' "c:\"

launches JupyterLab with the default notebook directory.

@stonebig
Copy link
Contributor

stonebig commented Apr 22, 2025

We lost that feature when simplifying launchers to something that was not scaring anti-viruses.
You can propose a nicer solution, if you have one, as lot of energy was lost in this battle.

the "/scripts/*.bat" second layer of launcher should still accept to forward command line, though

@stonebig
Copy link
Contributor

stonebig commented Apr 25, 2025

On experiment, just adding seems to make one or two anti-virus "instictively" unhappy.
... it may need to wait next cycle, given anti-viruses blind-guessed logic

Image

rechecking a little more

@firai
Copy link
Contributor Author

firai commented Apr 25, 2025

When I individually submitted the launchers I rebuilt, 1 or 2 antiviruses were unhappy. Rising, which I've never heard of, was the only one that complained about all of them.

@stonebig
Copy link
Contributor

here there is "Gridinsoft (no cloud)" and "Deep Instinct" .... removing pywin32 from my test flavor, to check further

@stonebig
Copy link
Contributor

otherwise, your lanchers looks perfectly ok, but rules are made per anti-viruses

@stonebig
Copy link
Contributor

apparently, removing pywin32 and 30' minutes, makes one or the two red flags go away .... hummm.

patch are ready if weather truly improve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants