Skip to content

new build method #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
stonebig opened this issue Oct 22, 2019 · 0 comments
Closed
2 tasks done

new build method #789

stonebig opened this issue Oct 22, 2019 · 0 comments

Comments

@stonebig
Copy link
Contributor

stonebig commented Oct 22, 2019

with winpython 2.2.20191022, we split the main process in 3:

  • step1:
    . using Winpython 'builder' environment (not final WinPython):
    . we build a first basic WinPython structure with make.py, without installer creation, nor any package but pip/setuptools/wheel,
  • step2:
    . moving inside WinPython target environment structure (the final WinPython),
    . pip install requirements.txt ,
    . run_complements.bat,
  • step3:
    . moving back to Winpython 'builder' environment (not final WinPython):
    . we re-use make.py a second time to publish the build: remove_existing=False, no package addition nor run_requirement, just rebuilding changelog and creating installer

benefit:

  • the goal: "run_complement.bat" step works again as expected on Python-3.8,
  • FAIL: the Jupyterlab 32 bit re-build, inside "run_complement.bat" still doesn't work, jupyterlab-1.2.0a3 for https://github.com/jupyterlab/jupyterlab/pull/7201/files,
  • make.py is unchanged,
  • ... so it's the technical build simplification, without yet the code simplification.

cost:

  • tweaking only "generate_a_winpython_distro.bat", not a technical big change
  • rename run_complement.bat as run_complement_newbuild.bat

the problem it shall solve will remain not understood, so still lurking around: Win10, Python-3.8, ...

@stonebig stonebig mentioned this issue Oct 22, 2019
7 tasks
stonebig added a commit to stonebig/winpython that referenced this issue Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant