Merge pull request mqttjs#93 from adamvr/will-qos-default-0

Adam Rudd · Adam Rudd · commit 67404f628f16 · 2013-05-28T03:34:37.000-07:00
Default will qos to 0 if not supplied or invalid
diff --git a/lib/generate.js b/lib/generate.js
@@ -71,10 +71,6 @@ module.exports.connect = function(opts) {
     } else {
       length += will.payload.length + 2;
     }
-    // It must have a number qos
-    if ('number' !== typeof will.qos) {
-      return new Error('Invalid will - invalid qos');
-    }
   }
 
   // Username
diff --git a/test/connection.transmit.js b/test/connection.transmit.js
@@ -421,7 +421,7 @@ module.exports = function() {
           this.conn.connect(fixture);
         });
 
-        it('should reject will with invalid qos', function(done) {
+        it.skip('should reject will with invalid qos', function(done) {
           var fixture = {
             protocolId: 'MQIsdp',
             protocolVersion: 3,

Original file line number	Diff line number	Diff line change
`@@ -71,10 +71,6 @@ module.exports.connect = function(opts) {`
`71`	`71`	`} else {`
`72`	`72`	`length += will.payload.length + 2;`
`73`	`73`	`}`
`74`		`- // It must have a number qos`
`75`		`- if ('number' !== typeof will.qos) {`
`76`		`- return new Error('Invalid will - invalid qos');`
`77`		`- }`
`78`	`74`	`}`
`79`	`75`
`80`	`76`	`// Username`