Explicitly check for None rather than falsey

jeffwidman · jeffwidman · commit 0bd5d2ab5738 · 2017-10-19T13:25:53.000-07:00
Be pedantic about checking for identity rather than equality to avoid issues like dpkp#1237 / 411bc08
diff --git a/kafka/client_async.py b/kafka/client_async.py
@@ -539,7 +539,7 @@ def poll(self, timeout_ms=None, future=None, delayed_tasks=True):
                         task_future.success(result)
 
             # If we got a future that is already done, don't block in _poll
-            if future and future.is_done:
+            if future is not None and future.is_done:
                 timeout = 0
             else:
                 idle_connection_timeout_ms = self._idle_expiry_manager.next_check_ms()
@@ -555,7 +555,7 @@ def poll(self, timeout_ms=None, future=None, delayed_tasks=True):
 
             # If all we had was a timeout (future is None) - only do one poll
             # If we do have a future, we keep looping until it is done
-            if not future or future.is_done:
+            if future is None or future.is_done:
                 break
 
         return responses
@@ -660,7 +660,7 @@ def least_loaded_node(self):
             conn = self._conns.get(node_id)
             connected = conn is not None and conn.connected()
             blacked_out = conn is not None and conn.blacked_out()
-            curr_inflight = len(conn.in_flight_requests) if conn else 0
+            curr_inflight = len(conn.in_flight_requests) if conn is not None else 0
             if connected and curr_inflight == 0:
                 # if we find an established connection
                 # with no in-flight requests, we can stop right away
