Skip to content

Commit 9911af2

Browse files
committed
support pybind11 and xtensor 0.27
1 parent 520e4f8 commit 9911af2

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ message(STATUS "xtensor-python v${${PROJECT_NAME}_VERSION}")
3232
# Dependencies
3333
# ============
3434

35-
set(xtensor_REQUIRED_VERSION 0.26.0)
35+
set(xtensor_REQUIRED_VERSION 0.27.0)
3636
if(TARGET xtensor)
3737
set(xtensor_VERSION ${XTENSOR_VERSION_MAJOR}.${XTENSOR_VERSION_MINOR}.${XTENSOR_VERSION_PATCH})
3838
# Note: This is not SEMVER compatible comparison
@@ -48,7 +48,7 @@ endif()
4848

4949
find_package(Python COMPONENTS Interpreter REQUIRED)
5050

51-
set(pybind11_REQUIRED_VERSION 2.6.1)
51+
set(pybind11_REQUIRED_VERSION 3.0.0)
5252
if (NOT TARGET pybind11::headers)
5353
# Defaults to ON for cmake >= 3.18
5454
# https://github.com/pybind/pybind11/blob/35ff42b56e9d34d9a944266eb25f2c899dbdfed7/CMakeLists.txt#L96

include/xtensor-python/pyarray.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ namespace xt
195195
static self_type ensure(pybind11::handle h);
196196
static bool check_(pybind11::handle h);
197197

198-
#if PYBIND11_VERSION_MAJOR == 2 && PYBIND11_VERSION_MINOR >= 3
198+
// #if PYBIND11_VERSION_MAJOR == 2 && PYBIND11_VERSION_MINOR >= 3
199199
// Prevent ambiguous overload resolution for operators defined for
200200
// both xt::xcontainer_semantic and pybind11::object.
201201
using semantic_base::operator+=;
@@ -207,7 +207,7 @@ namespace xt
207207
using semantic_base::operator^=;
208208
// using semantic_base::operator<<=;
209209
// using semantic_base::operator>>=;
210-
#endif
210+
// #endif
211211

212212
private:
213213

include/xtensor-python/pytensor.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ namespace xt
214214
static self_type ensure(pybind11::handle h);
215215
static bool check_(pybind11::handle h);
216216

217-
#if PYBIND11_VERSION_MAJOR == 2 && PYBIND11_VERSION_MINOR >= 3
217+
// #if PYBIND11_VERSION_MAJOR == 2 && PYBIND11_VERSION_MINOR >= 3
218218
// Prevent ambiguous overload resolution for operators defined for
219219
// both xt::xcontainer_semantic and pybind11::object.
220220
using semantic_base::operator+=;
@@ -226,7 +226,7 @@ namespace xt
226226
using semantic_base::operator^=;
227227
// using semantic_base::operator<<=;
228228
// using semantic_base::operator>>=;
229-
#endif
229+
// #endif
230230

231231
private:
232232

0 commit comments

Comments
 (0)