Skip to content

Commit 59093a9

Browse files
committed
Adding tests for responseType arraybuffer
1 parent d27cef3 commit 59093a9

File tree

2 files changed

+39
-1
lines changed

2 files changed

+39
-1
lines changed

lib/adapters/xhr.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,10 @@ module.exports = function xhrAdapter(resolve, reject, config) {
3434
if (request && request.readyState === 4) {
3535
// Prepare the response
3636
var headers = parseHeaders(request.getAllResponseHeaders());
37+
var responseData = ['text', ''].indexOf(config.responseType || '') !== -1 ? request.responseText : request.response;
3738
var response = {
3839
data: transformData(
39-
['text', ''].indexOf(config.responseType || '') !== -1 ? request.responseText : request.response,
40+
responseData,
4041
headers,
4142
config.transformResponse
4243
),

test/specs/wrapper.spec.js

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,4 +166,41 @@ describe('wrapper', function () {
166166
expect(request.requestHeaders['content-type']).toEqual(undefined);
167167
});
168168
});
169+
170+
// TODO this won't work until karma-jasmine updates to jasmine-ajax 2.99.0
171+
/*
172+
it('should support array buffer response', function () {
173+
var request, response;
174+
175+
runs(function () {
176+
axios({
177+
url: '/foo',
178+
responseType: 'arraybuffer'
179+
}).then(function (data) {
180+
response = data;
181+
});
182+
});
183+
184+
waitsFor(function () {
185+
return request = jasmine.Ajax.requests.mostRecent();
186+
}, 'waiting for the request', 100);
187+
188+
runs(function () {
189+
request.response({
190+
status: 200,
191+
response: new ArrayBuffer(16)
192+
});
193+
request.response = new ArrayBuffer(16);
194+
});
195+
196+
waitsFor(function () {
197+
return response;
198+
}, 'waiting for the response', 100);
199+
200+
runs(function () {
201+
expect(response.data.byteLength).toBe(16);
202+
});
203+
});
204+
*/
205+
169206
});

0 commit comments

Comments
 (0)