commit on exit = False by default

h0rn3t · h0rn3t · commit f1384aa95012 · 2021-04-26T15:27:46.000+03:00
diff --git a/fastapi_async_sqlalchemy/__init__.py b/fastapi_async_sqlalchemy/__init__.py
@@ -2,4 +2,4 @@
 
 __all__ = ["db", "SQLAlchemyMiddleware"]
 
-__version__ = "0.3.4"
+__version__ = "0.3.5"
diff --git a/fastapi_async_sqlalchemy/middleware.py b/fastapi_async_sqlalchemy/middleware.py
@@ -63,7 +63,7 @@ def session(self) -> AsyncSession:
 
 
 class DBSession(metaclass=DBSessionMeta):
-    def __init__(self, session_args: Dict = None, commit_on_exit: bool = True):
+    def __init__(self, session_args: Dict = None, commit_on_exit: bool = False):
         self.token = None
         self.session_args = session_args or {}
         self.commit_on_exit = commit_on_exit
diff --git a/tests/test_session.py b/tests/test_session.py
@@ -103,7 +103,7 @@ async def test_db_context_session_args(app, db, SQLAlchemyMiddleware, commit_on_
 
     session_args = {}
 
-    async with db(session_args=session_args):
+    async with db(session_args=session_args, commit_on_exit=True):
         assert isinstance(db.session, AsyncSession)
 
         # assert db.session.expire_on_commit

Original file line number	Diff line number	Diff line change
`@@ -2,4 +2,4 @@`
`2`	`2`
`3`	`3`	`__all__ = ["db", "SQLAlchemyMiddleware"]`
`4`	`4`
`5`		`-__version__ = "0.3.4"`
	`5`	`+__version__ = "0.3.5"`