Pull request updated...

Think we can get rid of my test for SQL_STAR (see the updated version in Join.php)... As far as I know, the only documented way to 'not' include columns from the joined table is to send an empty array. I also runned the soluble-flexstore unit tests (heavily relies on zend-db) with success.

See also improved functional tests (see SqlFunctionalTest.php)

PS:
I didn't test fully all possible 'undocumented' cases (like sending null or false instead of an empty array, some developers might have done it intuitively on older version). If anyone has ideas I tests different scenarios... Let me know

Thank you ! I can't believe this bug went through like that - I just updated to 2.8.0 and it broke a lot of stuff in my site

I fixed it myself by doing

$this->joins[] = [
            'name'    => $name,
            'on'      => $on,
            'columns' => $columns || is_array($columns) ? $columns : [Select::SQL_STAR],
            'type'    => $type ? $type : Join::JOIN_INNER
        ];

It was not working before because they were testing if $columns was true - but an empty array returns false;

so i check if $columns is true or if it is an array
if not i use the default SQL STAR

I can't believe this bug went through like that

I can; all tests passed locally when I merged, as well as on Travis. There simply weren't tests covering this particular behavior. Considering the enormity of SQL, there will always be edge cases we miss, as we cannot anticipate them all.

Thanks for the detailed reports, and thank you, @belgattitude, for the patch. I'll review and merge in the next day or so, and issue a release when I do.

@weierophinney you're welcome,

Thanks for all the good work and let me know in case i can help...

Seb