This repository was archived by the owner on Jan 8, 2020. It is now read-only.
Change to InputFilterFactory and CollectionInputFilter to support nested input-filter config #7554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s created via the Abstract Service Factory. Added functionality to retrieve nested InputFilters on the CollectionInputFilter via the Service Manager if available (allowing for nested InputFilter configurations).
|
Hi! can you pull this feature in your repository please? |
|
Please fix the travis errors, your fix seems to break things. Also unittests are missing. |
…ilterManager and ValidatorManager. Added Unit Testing assets and test to cover fix
| @@ -17,7 +17,7 @@ | |||
| /** | |||
| * Plugin manager implementation for input filters. | |||
| * | |||
| * @method InputFilterInterface|InputInterface get($name) | |||
| * @method InputFilterInterface|InputInterface get( $name ) | |||
There was a problem hiding this comment.
Please use PSR-2 coding style. No spaces here.
|
This might seem silly but can someone help me in diagnosing why the build is failing in 5.6? I'm not seeing any errors and 5.3-5.5 are passing just fine? |
|
@nobesnickr Please migrate your PR against the zend-inputfilter repo |
|
Ok I've created the PR against the zend-inputfilter repo (zendframework/zend-inputfilter#3). Let me know if anything else is needed |
|
Thanks this PR is ready to close :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've had some difficulty implementing InputFilterFactory via array config when needing to implement nested CollectionInputFilter; Specifically when using zf-content-validation.
My use case is such that input will have nested entities (and associated input filter configurations), and my problems arose from having to explicitly re-define/duplicate the validators because the base InputFilterPluginManager was not available downstream.
I'm suggesting the following changes that I've made to resolve this:
I encourage feedback and will be happy to re-work as needed as there may be a reason the InputFilterManager wasn't supplied in the factory initially.