find_trim: fix a crash when enabling line_art mode (libvips#3630)

kleisauke · web-flow · commit d9a2a04ee531 · 2023-09-10T15:29:54.000+02:00
diff --git a/libvips/arithmetic/find_trim.c b/libvips/arithmetic/find_trim.c
@@ -127,8 +127,8 @@ vips_find_trim_build(VipsObject *object)
 	if (!find_trim->line_art) {
 		if (vips_median(in, &t[1], 3, NULL))
 			return -1;
+		in = t[1];
 	}
-	in = t[1];
 
 	/* Smooth, find difference from bg, abs, threshold.
 	 */
diff --git a/test/test-suite/test_arithmetic.py b/test/test-suite/test_arithmetic.py
@@ -696,7 +696,8 @@ def test_find_trim(self):
                 assert height == 60
 
             test_rgb = test.bandjoin([test, test])
-            left, top, width, height = test_rgb.find_trim(background=[255, 255,
+            left, top, width, height = test_rgb.find_trim(line_art=True,
+                                                          background=[255, 255,
                                                                       255])
             assert left == 10
             assert top == 20

Original file line number	Diff line number	Diff line change
`@@ -127,8 +127,8 @@ vips_find_trim_build(VipsObject *object)`
`127`	`127`	`if (!find_trim->line_art) {`
`128`	`128`	`if (vips_median(in, &t[1], 3, NULL))`
`129`	`129`	`return -1;`
	`130`	`+ in = t[1];`
`130`	`131`	`}`
`131`		`- in = t[1];`
`132`	`132`
`133`	`133`	`/* Smooth, find difference from bg, abs, threshold.`
`134`	`134`	`*/`