Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: petoju/terraform-provider-mysql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: zph/terraform-provider-mysql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: r3.0.62
Choose a head ref
  • 8 commits
  • 2,812 files changed
  • 3 contributors

Commits on Jul 5, 2024

  1. Configuration menu
    Copy the full SHA
    a091819 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Add TiDB Resource Controls (#1)

    TODO
    ====
    - [ ] Setup automated testing for these changes
    - [ ] Offer upstream to petoju repo
    - [ ] Optionally build in lookups to see if current allocation is within
    limits of total predicted cluster capacity
    ```
    mysql> CALIBRATE RESOURCE START_TIME '2024-07-09 19:10:21' DURATION '30m';
    +--------+
    | QUOTA  |
    +--------+
    | 160194 |
    +--------+
    1 row in set (0.24 sec)
    
    That's approx NOW() - DURATION
    
    ```
    
    ---------
    
    Co-authored-by: Andrew Chen <andrewchen@plaid.com>
    zph and Andrew Chen authored Jul 19, 2024
    Configuration menu
    Copy the full SHA
    fbf0ca8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9534065 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Handle TF drift more gracefully for ti_resource_group and `ti_resou…

    …rce_group_assignment` (#5)
    
    [This
    article](https://www.hashicorp.com/blog/writing-custom-terraform-providers)
    provides a good initial explanation of the expected behaviors of the
    different CRUD methods for a resource.
    
    In it, it mentions that the `Read` method should be able to gracefully
    handle when the resource no longer exists (probably due to manual
    deletion).
    
    I also fixed a bug where `resourceGroup` was supposed to be
    `resource_group` and also modified `petoju` --> `zph` in certain places.
    This makes error logs a bit more clear.
    
    ---------
    
    Co-authored-by: Andrew Chen <andrewchen@plaid.com>
    otherchen and Andrew Chen authored Jul 23, 2024
    Configuration menu
    Copy the full SHA
    cc4f335 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Fixes TF drift for resource group name and query_limit (#6)

    This fixes the following drift:
    1. Resource group name would always be in quotes when pulled from the
    DB. This PR removes the quotes.
    2. Query Limit would always be missing `()` parentheses when pulled from
    the DB. This PR standardizes around the query_limit inside the
    parentheses. A breaking change is that we expect NO parenthesis to be
    passed in for the query_limit from now on. Instead, we will wrap the
    query_limit inside parentheses in the actual query rather than rely on
    the query_limit string being wrapped in parentheses by the caller.
    
    I also got basic tidb tests working and tested the above changes using
    `make testtidb7.5.1`
    
    ---------
    
    Co-authored-by: Andrew Chen <andrewchen@plaid.com>
    Co-authored-by: Zander Hill <zander@xargs.io>
    3 people authored Aug 9, 2024
    Configuration menu
    Copy the full SHA
    29408c9 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Support placement_policy resource and database configuration (#7)

    Supports creating a placement policy and adding it to a database:
    
    ```
    resource "mysql_ti_placement_policy" "test" {
        name = "%s"
        primary_region = "%s"
        regions = %s
        constraints = %s
    }
    
    resource "mysql_database" "test" {
        name = "%s"
        default_character_set = "%s"
        default_collation = "%s"
        placement_policy = mysql_ti_placement_policy.test.name
    }
    ```
    
    ---------
    
    Co-authored-by: Andrew Chen <andrewchen@plaid.com>
    Co-authored-by: Zander Hill <zander@xargs.io>
    3 people authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    c1c8d2a View commit details
    Browse the repository at this point in the history
  2. Zh r3.0.62 temp (#8)

    zph authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    4de34fd View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Update README.md (#9)

    zph authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    97f3783 View commit details
    Browse the repository at this point in the history
Loading