-
Notifications
You must be signed in to change notification settings - Fork 65
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: petoju/terraform-provider-mysql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: zph/terraform-provider-mysql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: r3.0.62
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 8 commits
- 2,812 files changed
- 3 contributors
Commits on Jul 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a091819 - Browse repository at this point
Copy the full SHA a091819View commit details
Commits on Jul 19, 2024
-
Add TiDB Resource Controls (#1)
TODO ==== - [ ] Setup automated testing for these changes - [ ] Offer upstream to petoju repo - [ ] Optionally build in lookups to see if current allocation is within limits of total predicted cluster capacity ``` mysql> CALIBRATE RESOURCE START_TIME '2024-07-09 19:10:21' DURATION '30m'; +--------+ | QUOTA | +--------+ | 160194 | +--------+ 1 row in set (0.24 sec) That's approx NOW() - DURATION ``` --------- Co-authored-by: Andrew Chen <andrewchen@plaid.com>
Configuration menu - View commit details
-
Copy full SHA for fbf0ca8 - Browse repository at this point
Copy the full SHA fbf0ca8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9534065 - Browse repository at this point
Copy the full SHA 9534065View commit details
Commits on Jul 23, 2024
-
Handle TF drift more gracefully for
ti_resource_group
and `ti_resou……rce_group_assignment` (#5) [This article](https://www.hashicorp.com/blog/writing-custom-terraform-providers) provides a good initial explanation of the expected behaviors of the different CRUD methods for a resource. In it, it mentions that the `Read` method should be able to gracefully handle when the resource no longer exists (probably due to manual deletion). I also fixed a bug where `resourceGroup` was supposed to be `resource_group` and also modified `petoju` --> `zph` in certain places. This makes error logs a bit more clear. --------- Co-authored-by: Andrew Chen <andrewchen@plaid.com>
Configuration menu - View commit details
-
Copy full SHA for cc4f335 - Browse repository at this point
Copy the full SHA cc4f335View commit details
Commits on Aug 9, 2024
-
Fixes TF drift for resource group name and query_limit (#6)
This fixes the following drift: 1. Resource group name would always be in quotes when pulled from the DB. This PR removes the quotes. 2. Query Limit would always be missing `()` parentheses when pulled from the DB. This PR standardizes around the query_limit inside the parentheses. A breaking change is that we expect NO parenthesis to be passed in for the query_limit from now on. Instead, we will wrap the query_limit inside parentheses in the actual query rather than rely on the query_limit string being wrapped in parentheses by the caller. I also got basic tidb tests working and tested the above changes using `make testtidb7.5.1` --------- Co-authored-by: Andrew Chen <andrewchen@plaid.com> Co-authored-by: Zander Hill <zander@xargs.io>
Configuration menu - View commit details
-
Copy full SHA for 29408c9 - Browse repository at this point
Copy the full SHA 29408c9View commit details
Commits on Sep 5, 2024
-
Support placement_policy resource and database configuration (#7)
Supports creating a placement policy and adding it to a database: ``` resource "mysql_ti_placement_policy" "test" { name = "%s" primary_region = "%s" regions = %s constraints = %s } resource "mysql_database" "test" { name = "%s" default_character_set = "%s" default_collation = "%s" placement_policy = mysql_ti_placement_policy.test.name } ``` --------- Co-authored-by: Andrew Chen <andrewchen@plaid.com> Co-authored-by: Zander Hill <zander@xargs.io>
Configuration menu - View commit details
-
Copy full SHA for c1c8d2a - Browse repository at this point
Copy the full SHA c1c8d2aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4de34fd - Browse repository at this point
Copy the full SHA 4de34fdView commit details
Commits on Sep 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 97f3783 - Browse repository at this point
Copy the full SHA 97f3783View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...r3.0.62