fix vuejs#512 attribute interpolation with filters

yyx990803 · yyx990803 · commit 0c01bcc72881 · 2014-10-27T15:08:52.000-04:00
diff --git a/src/parse/text.js b/src/parse/text.js
@@ -1,5 +1,6 @@
 var Cache = require('../cache')
 var config = require('../config')
+var dirParser = require('./directive')
 var regexEscapeRE = /[-.*+?^${}()|[\]\/\\]/g
 var cache, tagRE, htmlRE, firstChar, lastChar
 
@@ -106,6 +107,8 @@ exports.parse = function (text) {
 
 /**
  * Format a list of tokens into an expression.
+ * e.g. tokens parsed from 'a {{b}} c' can be serialized
+ * into one single expression as '"a " + b + " c"'.
  *
  * @param {Array} tokens
  * @param {Vue} [vm]
@@ -115,23 +118,61 @@ exports.parse = function (text) {
 exports.tokensToExp = function (tokens, vm) {
   return tokens.length > 1
     ? tokens.map(function (token) {
-      return formatToken(token, vm)
-    }).join('+')
-    : formatToken(tokens[0], vm)
+        return formatToken(token, vm)
+      }).join('+')
+    : formatToken(tokens[0], vm, true)
 }
 
 /**
  * Format a single token.
  *
  * @param {Object} token
  * @param {Vue} [vm]
+ * @param {Boolean} single
  * @return {String}
  */
 
-function formatToken (token, vm) {
+function formatToken (token, vm, single) {
   return token.tag
     ? vm && token.oneTime
-      ? '"' + vm.$get(token.value) + '"'
-      : '(' + token.value + ')'
+      ? '"' + vm.$eval(token.value) + '"'
+      : single
+        ? token.value
+        : inlineFilters(token.value)
     : '"' + token.value + '"'
+}
+
+/**
+ * For an attribute with multiple interpolation tags,
+ * e.g. attr="some-{{thing | filter}}", in order to combine
+ * the whole thing into a single watchable expression, we
+ * have to inline those filters. This function does exactly
+ * that. This is a bit hacky but it avoids heavy changes
+ * to directive parser and watcher mechanism.
+ *
+ * @param {String} exp
+ * @return {String}
+ */
+
+var filterRE = /[^|]\|[^|]/
+function inlineFilters (exp) {
+  if (!filterRE.test(exp)) {
+    return '(' + exp + ')'
+  } else {
+    var dir = dirParser.parse(exp)[0]
+    if (!dir.filters) {
+      return '(' + exp + ')'
+    } else {
+      exp = dir.expression
+      for (var i = 0, l = dir.filters.length; i < l; i++) {
+        var filter = dir.filters[i]
+        var args = filter.args
+          ? ',"' + filter.args.join('","') + '"'
+          : ''
+        exp = 'this.$options.filters["' + filter.name + '"]' +
+          '.apply(this,[' + exp + args + '])'
+      }
+      return exp
+    }
+  }
 }
diff --git a/test/unit/specs/compile/compile_spec.js b/test/unit/specs/compile/compile_spec.js
@@ -138,7 +138,7 @@ if (_.inBrowser) {
       data['{{*b}}'] = 'B'
       el.innerHTML = '<div a="{{a}}" b="{{*b}}"></div>'
       var def = Vue.options.directives.attr
-      var descriptor = dirParser.parse('a:(a)')[0]
+      var descriptor = dirParser.parse('a:a')[0]
       var linker = compile(el, Vue.options)
       linker(vm, el)
       expect(vm._bindDir.calls.count()).toBe(1)
diff --git a/test/unit/specs/parse/text_spec.js b/test/unit/specs/parse/text_spec.js
@@ -96,9 +96,9 @@ describe('Text Parser', function () {
   })
 
   it('tokens to expression', function () {
-    var tokens = textParser.parse('view-{{test + 1}}-test-{{ok}}')
+    var tokens = textParser.parse('view-{{test + 1}}-test-{{ok + "|"}}')
     var exp = textParser.tokensToExp(tokens)
-    expect(exp).toBe('"view-"+(test + 1)+"-test-"+(ok)')
+    expect(exp).toBe('"view-"+(test + 1)+"-test-"+(ok + "|")')
   })
 
   it('tokens to expression with oneTime tags & vm', function () {
@@ -110,4 +110,16 @@ describe('Text Parser', function () {
     expect(exp).toBe('"view-"+"a"+"-test-"+(ok)')
   })
 
+  it('tokens to expression with filters, single expression', function () {
+    var tokens = textParser.parse('{{test | abc}}')
+    var exp = textParser.tokensToExp(tokens)
+    expect(exp).toBe('test | abc')
+  })
+
+  it('tokens to expression with filters, multiple expressions', function () {
+    var tokens = textParser.parse('a {{b | c d}} e')
+    var exp = textParser.tokensToExp(tokens)
+    expect(exp).toBe('"a "+this.$options.filters["c"].apply(this,[b,"d"])+" e"')
+  })
+
 })
