number option for v-select (fixes vuejs#642)

yyx990803 · yyx990803 · commit c0726dc0d350 · 2014-12-22T21:32:40.000-05:00
diff --git a/src/directives/model/select.js b/src/directives/model/select.js
@@ -11,11 +11,15 @@ module.exports = {
     if (optionsParam) {
       initOptions.call(this, optionsParam)
     }
+    this.number = this._checkParam('number') != null
     this.multiple = el.hasAttribute('multiple')
     this.listener = function () {
       var value = self.multiple
         ? getMultiValue(el)
         : el.value
+      value = self.number
+        ? _.toNumber(value)
+        : value
       self.set(value, true)
     }
     _.on(el, 'change', this.listener)
@@ -124,7 +128,9 @@ function checkInitialValue () {
     }
   }
   if (initValue) {
-    this._initValue = initValue
+    this._initValue = this.number
+      ? _.toNumber(initValue)
+      : initValue
   }
 }
 
diff --git a/test/unit/specs/directives/model_spec.js b/test/unit/specs/directives/model_spec.js
@@ -273,6 +273,30 @@ if (_.inBrowser) {
       expect(opts[2].selected).toBe(false)
     })
 
+    it('select + number', function () {
+      var vm = new Vue({
+        el: el,
+        data: {
+          test: '1'
+        },
+        template: '<select v-model="test" number><option value="1">1</option></select>'
+      })
+      expect(vm.test).toBe('1')
+      trigger(vm.$el.firstChild, 'change')
+      expect(vm.test).toBe(1)
+    })
+
+    it('select + number initial value', function () {
+      var vm = new Vue({
+        el: el,
+        data: {
+          test: '1'
+        },
+        template: '<select v-model="test" number><option value="1" selected>1</option></select>'
+      })
+      expect(vm.test).toBe(1)
+    })
+
     it('text', function (done) {
       var vm = new Vue({
         el: el,

Original file line number	Diff line number	Diff line change
`@@ -11,11 +11,15 @@ module.exports = {`
`11`	`11`	`if (optionsParam) {`
`12`	`12`	`initOptions.call(this, optionsParam)`
`13`	`13`	`}`
	`14`	`+ this.number = this._checkParam('number') != null`
`14`	`15`	`this.multiple = el.hasAttribute('multiple')`
`15`	`16`	`this.listener = function () {`
`16`	`17`	`var value = self.multiple`
`17`	`18`	`? getMultiValue(el)`
`18`	`19`	`: el.value`
	`20`	`+ value = self.number`
	`21`	`+ ? _.toNumber(value)`
	`22`	`+ : value`
`19`	`23`	`self.set(value, true)`
`20`	`24`	`}`
`21`	`25`	`_.on(el, 'change', this.listener)`
`@@ -124,7 +128,9 @@ function checkInitialValue () {`
`124`	`128`	`}`
`125`	`129`	`}`
`126`	`130`	`if (initValue) {`
`127`		`- this._initValue = initValue`
	`131`	`+ this._initValue = this.number`
	`132`	`+ ? _.toNumber(initValue)`
	`133`	`+ : initValue`
`128`	`134`	`}`
`129`	`135`	`}`
`130`	`136`