Allow editing of image captions in place
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To

Authored By

	Esanders
	Nov 1 2016, 11:25 PM

Description

Most of the technical reasons why we didn't do this originally have since been overcome (e.g. handling a nested ce=true inside ce=false like we've since done with tables) and it would make for a more intuitive user experience.

We could either keep the media dialog as is, or get rid of the caption sub-surface and move everything onto one page.

Details

	Subject	Repo	Branch	Lines +/-
	Edit image captions in place	mediawiki/extensions/VisualEditor	master	+30 -5
	Factor out active node functionality from SectionNode for captions	VisualEditor/VisualEditor	master	+139 -69

Customize query in gerrit

Related Objects

Mentioned In: T53032: When inserting an image, set its caption by default to be the Commons image description
T248071: Inserting a list into an image caption renders raw wikitext
Mentioned Here: T149602: Allow rich text editing of image captions in gallery dialog

Event Timeline

Esanders created this task.Nov 1 2016, 11:25 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 1 2016, 11:25 PM

Change 320068 had a related patch set uploaded (by Esanders):
Factor out active node functionality from SectionNode for captions

https://gerrit.wikimedia.org/r/320068

gerritbot added a project: Patch-For-Review.Nov 6 2016, 12:38 AM

Change 320070 had a related patch set uploaded (by Esanders):
WIP Edit image captions in place

https://gerrit.wikimedia.org/r/320070

This should work for galleries too once we have native Parsoid support for them (T149602).

Jdforrester-WMF assigned this task to Esanders.Nov 8 2016, 8:11 PM

Jdforrester-WMF triaged this task as Low priority.

Jdforrester-WMF added projects: VisualEditor-MediaWiki-Media, User-notice.

Jdforrester-WMF updated the task description. (Show Details)

Jdforrester-WMF set the point value for this task to 8.

Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.

What does "in place" mean here? As opposed to?

In T149753#2785026, @Johan wrote:

What does "in place" mean here? As opposed to?

As opposed to in a dialog, like now.

Editing in a caption:

Editing "in-place"/directly in the document:

Change 320068 merged by jenkins-bot:
Factor out active node functionality from SectionNode for captions

https://gerrit.wikimedia.org/r/320068

Change 320070 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Edit image captions in place

https://gerrit.wikimedia.org/r/320070

Cool!

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJul 24 2017, 4:15 PM

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-07-25_(1.30.0-wmf.11)).Jul 24 2017, 5:00 PM

TheDJ awarded a token.Jul 24 2017, 5:57 PM

Ryasmeen edited projects, added Verified, Verified-in-Phase0; removed Patch-For-Review.Jul 26 2017, 7:32 PM

• Deskana merged a task: T76552: Make image captions directly editable in the main surface, without going into a dialog.Feb 23 2018, 4:57 PM

Trizek-WMF removed a project: User-notice.Mar 14 2018, 5:33 PM

Esanders mentioned this in T248071: Inserting a list into an image caption renders raw wikitext.May 20 2020, 1:42 PM

Esanders mentioned this in T53032: When inserting an image, set its caption by default to be the Commons image description.Jan 21 2021, 11:27 AM

	F4728732: pasted_file
	Nov 15 2016, 7:00 PM

	F4728728: pasted_file
	Nov 15 2016, 7:00 PM

Allow editing of image captions in placeClosed, ResolvedPublic8 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

Allow editing of image captions in place
Closed, ResolvedPublic8 Estimated Story Points
Actions