Page MenuHomePhabricator
Create Task
Maniphest T161285

CategorySelector should be renamed CategoryMultiselectWidget
Closed, ResolvedPublic
Actions

Description

All widgets in OOUI and Mediawiki have the Widget suffix, and the ones that use the multiselect widget have the Multiselect suffix. CategorySelector should thus be CategoryMultiselectWidget.

Details

SubjectRepoBranchLines +/-
[BREAKING CHANGE] Remove mw.widgets.CategorySelectormediawiki/coremaster+0 -3
ForeignStructuredUpload.BookletLayout: Use CategoryMultiselectWidgetmediawiki/coremaster+3 -3
Rename CategorySelector to CategoryMultiselectWidgetmediawiki/coremaster+51 -46
Use CategoryMultiselectWidget instead of CategorySelectormediawiki/extensions/UploadWizardmaster+2 -2
Customize query in gerrit

Event Timeline

• Prtksxna created this task.Mar 24 2017, 6:54 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 24 2017, 6:54 AM
gerritbot subscribed.Mar 24 2017, 10:00 AM

Change 344588 had a related patch set uploaded (by Prtksxna):
[mediawiki/core@master] Rename CategorySelector to CategorySelectorWidget

https://gerrit.wikimedia.org/r/344588

gerritbot added a project: Patch-For-Review.Mar 24 2017, 10:00 AM
gerritbot added a comment.Mar 24 2017, 10:28 AM

Change 344592 had a related patch set uploaded (by Prtksxna):
[mediawiki/core@master] ForeignStructuredUpload.BookletLayout: Use CategorySelectorWidget

https://gerrit.wikimedia.org/r/344592

gerritbot added a comment.Mar 24 2017, 10:32 AM

Change 344593 had a related patch set uploaded (by Prtksxna):
[mediawiki/extensions/UploadWizard@master] Use CategorySelectorWidget instead of CategorySelector

https://gerrit.wikimedia.org/r/344593

• Prtksxna added a comment.Mar 24 2017, 10:34 AM

Those three patches should cover it. I don't think its being used anywhere else.

• Prtksxna renamed this task from CategorySelector should be renamed CategorySelectorWidget to CategorySelector should be renamed CategoryMultiselectWidget.Mar 28 2017, 8:12 AM
• Prtksxna updated the task description. (Show Details)
gerritbot added a comment.Mar 28 2017, 9:16 PM

Change 344588 merged by jenkins-bot:
[mediawiki/core@master] Rename CategorySelector to CategoryMultiselectWidget

https://gerrit.wikimedia.org/r/344588

gerritbot added a comment.Mar 28 2017, 9:17 PM

Change 344592 merged by jenkins-bot:
[mediawiki/core@master] ForeignStructuredUpload.BookletLayout: Use CategoryMultiselectWidget

https://gerrit.wikimedia.org/r/344592

gerritbot added a comment.Mar 28 2017, 9:17 PM

Change 344593 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Use CategoryMultiselectWidget instead of CategorySelector

https://gerrit.wikimedia.org/r/344593

ReleaseTaggerBot added projects: MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)).Mar 28 2017, 10:00 PM
• Prtksxna added a comment.Mar 29 2017, 12:52 AM

@matmarex I don't think there are any other instances of CategorySelector that need to be replaced. Even so, till what time should we keep the deprecated class and RL module?

• Prtksxna claimed this task.Mar 29 2017, 12:53 AM
• Prtksxna removed a project: Patch-For-Review.
matmarex added a comment.Mar 29 2017, 7:46 PM

We actually have a shiny new policy at https://www.mediawiki.org/wiki/Deprecation that says "at least one major MediaWiki version". So we should wait for MW 1.29 to be released with the deprecation, and then we can remove it to land in MW 1.30. But this isn't a big burden to support, so I don't think there's any hurry. :)

matmarex closed this task as Resolved.Mar 29 2017, 7:47 PM
gerritbot added a comment.Apr 9 2018, 4:08 AM

Change 424976 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/core@master] [BREAKING CHANGE] Remove mw.widgets.CategorySelector

https://gerrit.wikimedia.org/r/424976

gerritbot added a project: Patch-For-Review.Apr 9 2018, 4:08 AM
gerritbot added a comment.Apr 9 2018, 4:12 PM

Change 424976 merged by jenkins-bot:
[mediawiki/core@master] [BREAKING CHANGE] Remove mw.widgets.CategorySelector

https://gerrit.wikimedia.org/r/424976

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)).Apr 9 2018, 5:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits