Page MenuHomePhabricator
Create Task
Maniphest T188509

Remove unnecessary parameters from URL
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Motivation
How a url looks like with advancedSearch enabled:
https://de.wikipedia.org/w/index.php?advancedSearchOption-original=literarische+beilage&search=literarische+beilage&title=Spezial:Suche&profile=advanced&fulltext=1&advancedSearchOption-filetype=&advancedSearch-current=%7B%22options%22%3A%7B%7D%2C%22namespaces%22%3A%5B%220%22%5D%7D&ns0=1&searchToken=a4sn3yyitxdreb1rc0x34bavg

Acceptance Criteria

  • The URL does not contain irrelevant information, such as the filetype or inlanguage parameters
  • The advancedSearch-current URL does not contain options values for empty fields

Note

This can by achieved by looking through the config parameters for widget constructors and removing all "name" entries.

Details

SubjectRepoBranchLines +/-
Do not double quote namespace numbers in the URLmediawiki/extensions/AdvancedSearchmaster+8 -4
Remove name attribute in test configmediawiki/extensions/AdvancedSearchmaster+0 -1
Omit empty fields in JSON serializationmediawiki/extensions/AdvancedSearchmaster+21 -2
Remove field namemediawiki/extensions/AdvancedSearchmaster+0 -2
Avoid poluting the browsers address bar with irrelevant optionsmediawiki/extensions/AdvancedSearchmaster+14 -8
Customize query in gerrit

Related Objects

Event Timeline

• Lea_WMDE created this task.Feb 28 2018, 1:48 PM
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptFeb 28 2018, 1:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• Lea_WMDE triaged this task as Medium priority.Feb 28 2018, 1:52 PM
• Lea_WMDE updated the task description. (Show Details)
• Lea_WMDE set the point value for this task to 2.
• Lea_WMDE updated the task description. (Show Details)
gabriel-wmde updated the task description. (Show Details)Mar 14 2018, 3:05 PM
gerritbot subscribed.Mar 21 2018, 2:30 PM

Change 392854 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/AdvancedSearch@master] Avoid poluting the browsers address bar with irrelevant options

https://gerrit.wikimedia.org/r/392854

gerritbot added a project: Patch-For-Review.Mar 21 2018, 2:30 PM
thiemowmde mentioned this in rEASRa184592c740f: Avoid poluting the browsers address bar with irrelevant options.Mar 21 2018, 2:31 PM
thiemowmde mentioned this in rEASRfa0a46ddb338: Show users default namespaces after submit without namespaces.Mar 26 2018, 7:44 AM
thiemowmde mentioned this in rEASR03d05072e8f5: Show users default namespaces after submit without namespaces.Mar 26 2018, 7:54 AM
thiemowmde mentioned this in rEASRcd6257f8c6b1: Show users default namespaces after submit without namespaces.Mar 26 2018, 8:07 AM
thiemowmde mentioned this in rEASRe470b05c7ffd: Avoid poluting the browsers address bar with irrelevant options.Mar 28 2018, 5:59 PM
thiemowmde mentioned this in rEASR55734bdd03d0: Avoid poluting the browsers address bar with irrelevant options.Mar 29 2018, 8:27 AM
• Lea_WMDE added a project: WMDE-FUN-Sprint-2018-04-04.Apr 4 2018, 12:56 PM
• Lea_WMDE moved this task from Todo to Review on the WMDE-FUN-Sprint-2018-04-04 board.
• Lea_WMDE moved this task from Tickets ready for pickup to In FUN sprint on the Advanced-Search board.Apr 4 2018, 1:00 PM
gabriel-wmde updated the task description. (Show Details)Apr 4 2018, 2:39 PM
gerritbot added a comment.Apr 4 2018, 2:45 PM

Change 392854 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Avoid poluting the browsers address bar with irrelevant options

https://gerrit.wikimedia.org/r/392854

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)).Apr 4 2018, 3:00 PM
• Tonina_Zhelyazkova_WMDE moved this task from Review to Deploy to Test on the WMDE-FUN-Sprint-2018-04-04 board.Apr 5 2018, 7:59 AM
gabriel-wmde claimed this task.Apr 5 2018, 9:07 AM
gabriel-wmde moved this task from Deploy to Test to Doing on the WMDE-FUN-Sprint-2018-04-04 board.
gabriel-wmde subscribed.

This item is not done yet - we still need to remove other params.

gerritbot added a comment.Apr 5 2018, 12:43 PM

Change 424292 had a related patch set uploaded (by Gabriel Birke; owner: Gabriel Birke):
[mediawiki/extensions/AdvancedSearch@master] Remove field name

https://gerrit.wikimedia.org/r/424292

gabriel-wmde mentioned this in rEASR5ef4c48f547c: Remove field name.Apr 5 2018, 12:45 PM
gerritbot added a comment.Apr 5 2018, 1:57 PM

Change 424307 had a related patch set uploaded (by Gabriel Birke; owner: Gabriel Birke):
[mediawiki/extensions/AdvancedSearch@master] Omit empty fields in JSON serialization

https://gerrit.wikimedia.org/r/424307

gabriel-wmde mentioned this in rEASRfccff801c633: Omit empty fields in JSON serialization.Apr 5 2018, 1:57 PM
gerritbot added a comment.Apr 5 2018, 3:12 PM

Change 424307 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Omit empty fields in JSON serialization

https://gerrit.wikimedia.org/r/424307

gabriel-wmde mentioned this in rEASRe6757ed40f61: Remove field name.Apr 5 2018, 3:21 PM
gabriel-wmde moved this task from Doing to Deploy to Test on the WMDE-FUN-Sprint-2018-04-04 board.Apr 5 2018, 3:22 PM
gerritbot added a comment.Apr 5 2018, 4:49 PM

Change 424292 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Remove field name

https://gerrit.wikimedia.org/r/424292

gabriel-wmde removed gabriel-wmde as the assignee of this task.Apr 9 2018, 9:52 AM
gerritbot added a comment.Apr 10 2018, 11:32 AM

Change 425250 had a related patch set uploaded (by Gabriel Birke; owner: Gabriel Birke):
[mediawiki/extensions/AdvancedSearch@master] Remove name attribute in test config

https://gerrit.wikimedia.org/r/425250

gabriel-wmde mentioned this in rEASRe08ca8526836: Remove name attribute in test config.Apr 10 2018, 11:33 AM
gerritbot added a comment.Apr 10 2018, 2:19 PM

Change 425250 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Remove name attribute in test config

https://gerrit.wikimedia.org/r/425250

gabriel-wmde moved this task from Deploy to Test to Test on the WMDE-FUN-Sprint-2018-04-04 board.Apr 10 2018, 3:23 PM

Deployed to test server

• Lea_WMDE moved this task from Test to Deploy on the WMDE-FUN-Sprint-2018-04-04 board.Apr 12 2018, 10:00 AM
• Lea_WMDE moved this task from Deploy to Done on the WMDE-FUN-Sprint-2018-04-04 board.
thiemowmde moved this task from Incoming to Advanced Search on the TCB-Team (now WMDE-TechWish) board.Jun 12 2018, 4:06 PM
gerritbot added a comment.Jun 18 2018, 12:49 PM

Change 440854 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/AdvancedSearch@master] Do not double quote namespace numbers in the URL

https://gerrit.wikimedia.org/r/440854

thiemowmde mentioned this in rEASRd239e480ae57: Do not double quote namespace numbers in the URL.Jun 18 2018, 12:51 PM
gerritbot added a comment.Jun 19 2018, 8:34 AM

Change 440854 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Do not double quote namespace numbers in the URL

https://gerrit.wikimedia.org/r/440854

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jun 30 2018, 1:01 PM
• Lea_WMDE closed this task as Resolved.Oct 11 2018, 8:51 AM
thiemowmde removed a project: TCB-Team (now WMDE-TechWish).Jan 7 2022, 2:48 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits