Maniphest T190582

Active link annotation styling conflicts with "plainlinks" class
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	matmarex
	Mar 23 2018, 9:52 PM

Description

Syntax like <span class="plainlinks">/<div class="plainlinks"> is used in wikitext to suppress the little arrow shown next to external links. In some cases the entire page can be wrapped in that. It seems to conflict with our active link annotation styling, for example on https://en.wikipedia.org/wiki/Butch_Miles?veaction=edit:

Normal styling
Broken styling

Details

	Subject	Repo	Branch	Lines +/-
	MWExternalLinkAnnotation: add CSS to override plainlinks styling	mediawiki/extensions/VisualEditor	master	+18 -1

Customize query in gerrit

Event Timeline

matmarex created this task.Mar 23 2018, 9:52 PM

Restricted Application added a project: VisualEditor. · View Herald TranscriptMar 23 2018, 9:52 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

matmarex triaged this task as Medium priority.Mar 27 2018, 10:54 AM

It's an !important issue:

In MW core we have:

.plainlinks a {
	background: none !important;
	padding: 0 !important;
}

DLynch claimed this task.Mar 27 2018, 5:01 PM

DLynch edited projects, added VisualEditor (Current work); removed VisualEditor.Mar 28 2018, 3:59 PM

Change 422427 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] MWExternalLinkAnnotation: add CSS to override plainlinks styling

https://gerrit.wikimedia.org/r/422427

gerritbot added a project: Patch-For-Review.Mar 28 2018, 4:00 PM

DLynch moved this task from Incoming to Code review on the VisualEditor (Current work) board.Mar 28 2018, 4:00 PM

Change 422427 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] MWExternalLinkAnnotation: add CSS to override plainlinks styling

https://gerrit.wikimedia.org/r/422427

Jdforrester-WMF moved this task from Code review to Product owner review on the VisualEditor (Current work) board.Apr 4 2018, 3:56 PM

Jdforrester-WMF removed a project: Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)).Apr 4 2018, 4:00 PM

• Deskana closed this task as Resolved.Apr 9 2018, 3:34 PM

• Deskana set the point value for this task to 1.