Page MenuHomePhabricator
Create Task
Maniphest T190685

Some pages are timing out: Maximum execution time of 15 seconds exceeded in extensions/Translate/messagegroups/AggregateMessageGroup.php on line 171
Closed, ResolvedPublic
Actions

Description

Since we switched from HHVM to PHP, this has been happening frequently. Initially seen on API messagecollection for group=core-0-mostused, now also reported for https://translatewiki.net/w/i.php?title=Special%3ALanguageStats&x=D&language=ko&suppresscomplete=1

Details

SubjectRepoBranchLines +/-
Optimize AggregateMessageGroup::getKeysmediawiki/extensions/Translatemaster+6 -6
Customize query in gerrit

Event Timeline

Nikerabbit created this task.Mar 26 2018, 1:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 26 2018, 1:23 PM
Nikerabbit triaged this task as High priority.Mar 26 2018, 1:23 PM
Nikerabbit added a project: Language-2018-Jan-Mar.
revi subscribed.Mar 26 2018, 1:24 PM
Pginer-WMF moved this task from Backlog to Maintenance backlog on the Language-2018-Jan-Mar board.Mar 27 2018, 7:36 AM
Pginer-WMF added a project: Language-2018-Apr-June.Mar 28 2018, 9:57 AM
Pginer-WMF moved this task from Backlog to Maintenance backlog on the Language-2018-Apr-June board.Apr 3 2018, 6:56 AM
Pginer-WMF removed a project: Language-2018-Jan-Mar.Apr 3 2018, 8:24 AM
gerritbot subscribed.Apr 3 2018, 2:40 PM

Change 423705 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/Translate@master] Optimize AggregateMessageGroup::getKeys

https://gerrit.wikimedia.org/r/423705

gerritbot added a project: Patch-For-Review.Apr 3 2018, 2:40 PM
Nikerabbit moved this task from Maintenance backlog to In Review on the Language-2018-Apr-June board.Apr 3 2018, 3:01 PM

I cherry-picked and deployed the patch on translatewiki.net. createMessageIndex.php is now taking ~7 s and the URLs from the slowlog are now responding quickly.

gerritbot added a comment.Apr 4 2018, 12:01 PM

Change 423705 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Optimize AggregateMessageGroup::getKeys

https://gerrit.wikimedia.org/r/423705

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)).Apr 4 2018, 1:00 PM
Nikerabbit edited projects, added MediaWiki-extensions-Translate; removed Patch-For-Review.Apr 5 2018, 6:47 AM
Nikerabbit moved this task from In Review to Done on the Language-2018-Apr-June board.

I am moving this directly to done, because I have been using this patch in translatewiki.net without issues.

Nikerabbit moved this task from Backlog to maintenance and operational issues on the MediaWiki-extensions-Translate board.Apr 5 2018, 6:47 AM
Nikerabbit closed this task as Resolved.Apr 6 2018, 3:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits