Maniphest T191234

Tranclusion dialog is shown with horizontal scrollbar because the "Add template" button doesn't fit when Options section is appearing on the left side
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Ryasmeen
	Apr 2 2018, 6:43 PM

Description

Steps to reproduce:

Open tranclusion dialog
Insert a template
Click on "Show Options"
Click on the puzzle icon on the bottom-left corner of the dialog

The "Add template" button for the second template entry is out of view now with horizontal scrollbar appearing on the dialog.

Beta:

Screen Shot 2018-04-02 at 10.05.19 AM.png (217×758 px, 20 KB)

Test2:

Screen Shot 2018-04-02 at 11.34.45 AM.png (497×718 px, 55 KB)

Details

	Subject	Repo	Branch	Lines +/-
	MWTransclusionDialog: remove extra padding from framesets	mediawiki/extensions/VisualEditor	master	+1 -5

Customize query in gerrit

Event Timeline

Ryasmeen created this task.Apr 2 2018, 6:43 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 2 2018, 6:43 PM

• Deskana triaged this task as High priority.Apr 3 2018, 6:43 PM

• Deskana moved this task from To Triage to Current work on the VisualEditor board.

• Deskana edited projects, added VisualEditor (Current work); removed VisualEditor.

• Deskana added a project: Regression.

DLynch claimed this task.Apr 5 2018, 3:50 PM

DLynch moved this task from Incoming to In progress on the VisualEditor (Current work) board.

Change 424343 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] MWTransclusionDialog: frameset left-margin only when menu is closed

https://gerrit.wikimedia.org/r/424343

gerritbot added a project: Patch-For-Review.Apr 5 2018, 3:56 PM

DLynch moved this task from In progress to Code review on the VisualEditor (Current work) board.Apr 5 2018, 3:57 PM

Change 424343 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] MWTransclusionDialog: remove extra padding from framesets

https://gerrit.wikimedia.org/r/424343

Jdforrester-WMF moved this task from Code review to Product owner review on the VisualEditor (Current work) board.Apr 5 2018, 5:35 PM

Jdforrester-WMF removed a project: Patch-For-Review.

Jdforrester-WMF edited projects, added VisualEditor-MediaWiki-Templates; removed OOUI.

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)).Apr 5 2018, 6:00 PM

Ryasmeen added a project: Verified.Apr 5 2018, 11:03 PM

• Deskana closed this task as Resolved.Apr 9 2018, 3:26 PM

• Deskana set the point value for this task to 1.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptApr 9 2018, 3:26 PM

	F16600480: Screen Shot 2018-04-02 at 11.34.45 AM.png
	Apr 2 2018, 6:43 PM

	F16600478: Screen Shot 2018-04-02 at 10.05.19 AM.png
	Apr 2 2018, 6:43 PM

Tranclusion dialog is shown with horizontal scrollbar because the "Add template" button doesn't fit when Options section is appearing on the left side Closed, ResolvedPublic1 Estimated Story PointsActions

Description

Details

Event Timeline

Tranclusion dialog is shown with horizontal scrollbar because the "Add template" button doesn't fit when Options section is appearing on the left side
Closed, ResolvedPublic1 Estimated Story Points
Actions