Page MenuHomePhabricator
Create Task
Maniphest T191512

PHP fatal error: [] operator not supported for strings @ group0 and group1
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

PHP fatal error: [] operator not supported for strings @ https://commons.wikimedia.org/w/index.php?title=Special:AbuseFilter&offset=129

This fatal error has affected group0 and group1.

More details from my local machine:

Error from line 400 of W:\xampp\htdocs\pedia\includes\pager\IndexPager.php: [] operator not supported for strings

Backtrace:

#0 W:\xampp\htdocs\pedia\includes\pager\IndexPager.php(366): IndexPager->buildQueryInfo(string, integer, boolean)
#1 W:\xampp\htdocs\pedia\includes\pager\IndexPager.php(217): IndexPager->reallyDoQuery(string, integer, boolean)
#2 W:\xampp\htdocs\pedia\includes\pager\IndexPager.php(608): IndexPager->doQuery()
#3 W:\xampp\htdocs\pedia\includes\pager\TablePager.php(292): IndexPager->isNavigationBarShown()
#4 W:\xampp\htdocs\pedia\extensions\AbuseFilter\includes\Views\AbuseFilterViewList.php(230): TablePager->getNavigationBar()
#5 W:\xampp\htdocs\pedia\extensions\AbuseFilter\includes\Views\AbuseFilterViewList.php(104): AbuseFilterViewList->showList(string, array)
#6 W:\xampp\htdocs\pedia\extensions\AbuseFilter\includes\special\SpecialAbuseFilter.php(116): AbuseFilterViewList->show()
#7 W:\xampp\htdocs\pedia\includes\specialpage\SpecialPage.php(522): SpecialAbuseFilter->execute(string)
#8 W:\xampp\htdocs\pedia\includes\specialpage\SpecialPageFactory.php(579): SpecialPage->run(string)
#9 W:\xampp\htdocs\pedia\includes\MediaWiki.php(288): SpecialPageFactory::executePath(Title, RequestContext)
#10 W:\xampp\htdocs\pedia\includes\MediaWiki.php(861): MediaWiki->performRequest()
#11 W:\xampp\htdocs\pedia\includes\MediaWiki.php(524): MediaWiki->main()
#12 W:\xampp\htdocs\pedia\index.php(42): MediaWiki->run()
#13 {main}

Details

SubjectRepoBranchLines +/-
Remove superfluous linemediawiki/extensions/AbuseFilterwmf/1.31.0-wmf.28+0 -2
Remove superfluous linemediawiki/extensions/AbuseFiltermaster+0 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Midleading created this task.Apr 5 2018, 9:56 AM
Restricted Application added subscribers: • OldUser02, Aklapper. · View Herald TranscriptApr 5 2018, 9:56 AM
Reedy added a project: Wikimedia-production-error.Apr 5 2018, 10:39 AM
Daimona triaged this task as Unbreak Now! priority.Apr 5 2018, 12:35 PM
Daimona subscribed.

Due to https://gerrit.wikimedia.org/r/#/c/411593/. Prevents from changing page in Special:AbuseFilter. I'll investigate in a moment.

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptApr 5 2018, 12:35 PM
Daimona updated the task description. (Show Details)Apr 5 2018, 12:44 PM
Daimona added a comment.Apr 5 2018, 1:27 PM

I got the problem, not yet a solution. With getQueryInfo in AbuseFilterPager, we pass as 'conds' a string instead of an array. This is because we need quite a complex query, which we can't achieve with array notation. I'm still looking for a solution.

gerritbot subscribed.Apr 5 2018, 1:41 PM

Change 424305 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Always make $conds an array

https://gerrit.wikimedia.org/r/424305

gerritbot added a project: Patch-For-Review.Apr 5 2018, 1:41 PM
Daimona claimed this task.Apr 5 2018, 1:42 PM
Daimona added a parent task: T183967: 1.31.0-wmf.28 deployment blockers.
Huji added projects: Regression, Technical-Debt.Apr 5 2018, 2:57 PM
RazeSoldier renamed this task from PHP fatal error: [] operator not supported for strings @ https://commons.wikimedia.org/w/index.php?title=Special:AbuseFilter&offset=129 to PHP fatal error: [] operator not supported for strings @ group0 and group1.Apr 5 2018, 3:25 PM
RazeSoldier updated the task description. (Show Details)
gerritbot added a comment.Apr 5 2018, 4:03 PM

Change 424345 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@wmf/1.31.0-wmf.28] Remove superfluous line

https://gerrit.wikimedia.org/r/424345

gerritbot added a comment.Apr 5 2018, 4:17 PM

Change 424305 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Remove superfluous line

https://gerrit.wikimedia.org/r/424305

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)).Apr 5 2018, 5:00 PM
gerritbot added a comment.Apr 5 2018, 6:17 PM

Change 424345 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@wmf/1.31.0-wmf.28] Remove superfluous line

https://gerrit.wikimedia.org/r/424345

Stashbot subscribed.Apr 5 2018, 6:25 PM

Mentioned in SAL (#wikimedia-operations) [2018-04-05T18:25:35Z] <catrope@tin> Synchronized php-1.31.0-wmf.28/extensions/AbuseFilter/includes/Views/AbuseFilterViewList.php: Unbreak Special:AbuseFilter (T191512) (duration: 01m 17s)

Daimona closed this task as Resolved.Apr 5 2018, 6:28 PM
ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)); removed MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)).Apr 5 2018, 7:00 PM
Liuxinyu970226 unsubscribed.Apr 6 2018, 4:07 AM
Daimona removed a project: Patch-For-Review.Jun 8 2018, 4:18 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:09 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits