Page MenuHomePhabricator
Create Task
Maniphest T214775

Prevent redirecting an entity to itself
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Problem:
It's possible to redirect an Item onto itself, and redirecting Lexemes to itself results in strange bugs (T214774: Redirecting a Lexeme to itself results in a corrupted Lexeme). This should not be possible.

Example:
https://test.wikidata.org/w/index.php?title=Q193394&oldid=461880

This has been broken down into 2 sub tasks

Related Objects
Search...

Event Timeline

Bugreporter created this task.Jan 26 2019, 10:14 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 26 2019, 10:15 PM
Bugreporter renamed this task from It should not be possible to redirect an entity to itself. to It should not be possible to redirect an entity to itself.Jan 26 2019, 10:16 PM
Lydia_Pintscher added a project: Wikidata-Campsite.Jan 27 2019, 12:18 PM
Lydia_Pintscher renamed this task from It should not be possible to redirect an entity to itself to Prevent redirecting an entity to itself.Jan 29 2019, 11:24 AM
Lydia_Pintscher updated the task description. (Show Details)
Lydia_Pintscher moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.
Bugreporter added a comment.Jan 29 2019, 11:30 AM

Special:MergeItem or Special:MergeLexeme already check whether two entities are the same. Special:RedirectEntity does not.

Lydia_Pintscher subscribed.Jan 29 2019, 12:31 PM

Oh thank you! I misunderstood then.

Lydia_Pintscher updated the task description. (Show Details)Jan 29 2019, 12:32 PM

Correct now?

Addshore triaged this task as High priority.Jan 29 2019, 2:14 PM
Addshore merged a task: T214774: Redirecting a Lexeme to itself results in a corrupted Lexeme.
Addshore set the point value for this task to 5.
Addshore moved this task from Ready to estimate to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.
Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Addshore added subscribers: Sjoerddebruin, TerraCodes, Liuxinyu970226.
Addshore mentioned this in T214919: Prevent redirecting an entity to itself - using Special:RedirectEntity.Jan 29 2019, 2:28 PM
Addshore updated the task description. (Show Details)
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 29 2019, 3:34 PM
Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.Jan 30 2019, 11:50 AM
Addshore closed subtask T214919: Prevent redirecting an entity to itself - using Special:RedirectEntity as Resolved.Jan 31 2019, 3:01 PM
Ladsgroup moved this task from Doing to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 5 2019, 9:37 AM
Addshore closed this task as Resolved.Feb 8 2019, 9:30 AM
Addshore claimed this task.
Addshore moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Addshore subscribed.

image.png (332×778 px, 20 KB)

Restricted Application added a project: User-Addshore. · View Herald TranscriptFeb 8 2019, 9:31 AM
Addshore closed subtask T214920: Prevent redirecting an entity to itself - In the Wikibase DataModel as Resolved.Feb 8 2019, 9:31 AM
Liuxinyu970226 unsubscribed.Feb 10 2019, 12:34 PM
Lucas_Werkmeister_WMDE mentioned this in T217329: bug in 1.33.0-wmf.18+ breaks abstract dumps on testwikidatawiki, among other things | MWContentSerializationException $entityId and $targetId can not be the same.Feb 28 2019, 4:25 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits