[Regression ?] "Next" button stays disabled on MobileFrontend wikitext editor after switching from Mobile VE
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ryasmeen
	Mar 5 2019, 1:12 AM

Description

Steps to replicate:

Open Mobile VE for any page.
Switch to wikitext
Type something

The "Next" button stays disabled even after making a change on the surface.

Details

	Subject	Repo	Branch	Lines +/-
	EditorOverlay: deep-extend of options in constructor	mediawiki/extensions/MobileFrontend	master	+6 -6

Customize query in gerrit

Related Objects

Mentioned In: T217375: on mobile web source editor, "Next" button stays grayed out after changing source if edit started in visual editor
Mentioned Here: rEMFRa8be7d15e94a: Breaking: replace View.events with constructor args

Event Timeline

Ryasmeen created this task.Mar 5 2019, 1:12 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 5 2019, 1:12 AM

Ryasmeen renamed this task from [Regression ?] "Next" button stays disabled on Mobile NWE after saving an edit to [Regression ?] "Next" button stays disabled on Mobile NWE after saving an edit with Mobile VE.Mar 5 2019, 1:12 AM

Ryasmeen renamed this task from [Regression ?] "Next" button stays disabled on Mobile NWE after saving an edit with Mobile VE to [Regression ?] "Next" button stays disabled on Mobile NWE after switching from Mobile VE.Mar 5 2019, 1:16 AM

Ryasmeen updated the task description. (Show Details)

JTannerWMF moved this task from To Triage to Needs Discussion/Analysis on the VisualEditor board.Mar 5 2019, 3:59 PM

Btw, this is happening on en.wiki too, therefore setting up the priority as at-least High if not UBN. Talked to @ppelberg about it.

Ryasmeen triaged this task as High priority.Mar 6 2019, 1:29 AM

Esanders renamed this task from [Regression ?] "Next" button stays disabled on Mobile NWE after switching from Mobile VE to [Regression ?] "Next" button stays disabled on MobileFrontend wikitext editor after switching from Mobile VE.Mar 6 2019, 5:51 PM

Esanders added a project: VisualEditor-MediaWiki-Mobile.

Esanders updated the task description. (Show Details)

Esanders added a subscriber: matmarex.

Seems to be the result of a8be7d15e94a8e by @Niedzielski, which changed how constructors initialize events. It passes event handlers into constructors, and does a non-deep merge of existing options with util.extend. This breaks if the existing options have any event handlers already.

Change 495002 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/MobileFrontend@master] EditorOverlay: deep-extend of options in constructor

https://gerrit.wikimedia.org/r/495002

gerritbot added a project: Patch-For-Review.Mar 7 2019, 6:14 PM

That patch handles this ticket's case. We should probably go through all the changes in that patch and make sure that switching them to deep-extend won't cause any issues.

Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.Mar 7 2019, 6:18 PM

Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.

Change 495002 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] EditorOverlay: deep-extend of options in constructor

https://gerrit.wikimedia.org/r/495002

DLynch moved this task from Code review to QA on the VisualEditor (Current work) board.Mar 7 2019, 8:59 PM

Perfect! Verified the fix. Thanks @DLynch.

ppelberg closed this task as Resolved.Mar 7 2019, 11:37 PM

ppelberg awarded a token.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMar 7 2019, 11:38 PM

ppelberg mentioned this in T217375: on mobile web source editor, "Next" button stays grayed out after changing source if edit started in visual editor.Mar 12 2019, 3:46 PM

DLynch merged a task: T217375: on mobile web source editor, "Next" button stays grayed out after changing source if edit started in visual editor.Mar 13 2019, 5:59 PM

DLynch added subscribers: jeremyb, DLynch, kostajh, • iamjessklein.

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.22; 2019-03-19).Mar 16 2019, 8:31 PM

[Regression ?] "Next" button stays disabled on MobileFrontend wikitext editor after switching from Mobile VEClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

[Regression ?] "Next" button stays disabled on MobileFrontend wikitext editor after switching from Mobile VE
Closed, ResolvedPublic
Actions