Page MenuHomePhabricator

Add missing / to self closing input element in search box template
Closed, ResolvedPublic

Description

Currenty the HTML output is:

  <form action="/w/index.php" id="searchform">
	  <div id="simpleSearch" data-search-loc="header-navigation">
		<input type="search" name="search" placeholder="Wikipedia durchsuchen" autocapitalize="sentences" title="Durchsuche die Wikipedia [f]" accesskey="f" id="searchInput"/>
		<input type="hidden" name="title" value="Spezial:Suche">
		<input type="submit" name="fulltext" value="Suchen" title="Suche nach Seiten, die diesen Text enthalten" id="mw-searchButton" class="searchButton mw-fallbackSearchButton"/>
		<input type="submit" name="go" value="Artikel" title="Gehe direkt zu der Seite mit genau diesem Namen, falls sie vorhanden ist." id="searchButton" class="searchButton"/>
  	</div>
  </form>

The hidden inpiut element is not self closing.

Inconsistency spotted by Patrick Sahle: https://twitter.com/patrick_sahle/status/1351991811066257412

Follow up to https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/599968

Event Timeline

Change 657573 had a related patch set uploaded (by Raimond Spekking; owner: Raimond Spekking):
[mediawiki/skins/Vector@master] Add missing / for self-closing input element

https://gerrit.wikimedia.org/r/657573

Change 657573 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Add missing / for self-closing input element

https://gerrit.wikimedia.org/r/657573