Moroccan Arabic is shown as LTR in MobileFrontend's interlanguage links list. It's probably because it's not in rtlLanguages.js.
QA Results - Prod
AC | Status | Details |
---|---|---|
1 | ✅ | T342447#9066890 |
Amire80 | |
Jul 21 2023, 3:47 PM |
F37162043: Screenshot 2023-08-03 at 7.30.26 AM.png | |
Aug 3 2023, 2:34 PM |
Moroccan Arabic is shown as LTR in MobileFrontend's interlanguage links list. It's probably because it's not in rtlLanguages.js.
AC | Status | Details |
---|---|---|
1 | ✅ | T342447#9066890 |
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Add several RTL languages: acm, ary, hno, ms-arab | mediawiki/extensions/MobileFrontend | master | +6 -2 |
Change 940385 had a related patch set uploaded (by Amire80; author: Amire80):
[mediawiki/extensions/MobileFrontend@master] Add several RTL languages: acm, ary, hno, ms-arab
Also documented in Manual:Adding_and_removing_languages: https://www.mediawiki.org/w/index.php?title=Manual%3AAdding_and_removing_languages&diff=6035456&oldid=6022265 .
Change 940385 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Add several RTL languages: acm, ary, hno, ms-arab
Why isn’t rtLanguages.js a generated package file? That’s exactly what generated files are for. The PHP code generating the file could go over the list of supported MediaWiki languages and generate the list on-the-fly, without the need for extra commits to the MF repo whenever a new language is added to core.
Why isn’t rtLanguages.js a generated package file? That’s exactly what generated files are for. The PHP code generating the file could go over the list of supported MediaWiki languages and generate the list on-the-fly, without the need for extra commits to the MF repo whenever a new language is added to core.
This is a workaround for a performance issue in core. Ideally RTL information should be on the language links themselves but we had to revert https://gerrit.wikimedia.org/r/c/mediawiki/core/+/911367 due to a performance regression.
I believe using a generated package file could provide acceptable performance. Let’s continue at T342603: Generate the list of right-to-left languages automatically in MobileFrontend.
Status: ✅ PASS
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA
Test Artifact(s):
✅ AC1: Moroccan Arabic should be shown as RTL in the language list.